Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_gateway - fixes a crash where ssl_policy is nil when importing #935

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This isn't possible to write a test for since it relies on an older version of the schema being returned from the API - but I've verified the response in this crash log which confirms this isn't returned (and that it'll crash here

Fixes #933

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit ec5e6ac into master Mar 5, 2018
@tombuildsstuff tombuildsstuff deleted the app-gateway-crash branch March 5, 2018 23:43
tombuildsstuff added a commit that referenced this pull request Mar 5, 2018
@avnsiva
Copy link

avnsiva commented Mar 7, 2018

Hi, Great to know that this is fixed. Will I be able to get a binary of terraform with this fix?

@tombuildsstuff
Copy link
Contributor Author

@avnsiva this'll be released in v1.3 in the near future (we'll comment on the issue when that's released), if you need it before then you can build a custom binary using the instructions in the readme

Hope that helps :)

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform crashed when trying to import azurerm application gateway
3 participants