-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support ipv6 configuration in azurerm_express_route_circuit_peering #9235
Merged
katbyte
merged 12 commits into
hashicorp:master
from
xuzhang3:f/expressroutecircuitpeering_enhance
Nov 23, 2020
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df2e13f
add ipv6 config for express_route_circuit_peering
21e9a11
add ipv6 config for express_route_circuit_peering
2c6bb0a
Merge remote-tracking branch 'upstream/master' into f/expressroutecir…
0f62b6e
* change microsoft_peering_config from optional to required
aeb69c0
TF script format
57ddac4
fix linter issues
9a89b82
fix linter issues
7b6a88c
rename and validation update
9e6d80c
document update
22d5c33
formatting
jackofallops e7b1ad7
document update and constraint check
c48b31c
document update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add validation to check this is not set when incompatible types are used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a check for this anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why GitHub does not display the latest code. I have add a check for
routeFilterId
. https://github.com/xuzhang3/terraform-provider-azurerm/blob/f/expressroutecircuitpeering_enhance/azurerm/internal/services/network/express_route_circuit_peering_resource.go#L400There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see a check to make sure route filter id is not set when type is microsoft in that link..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipv6
is a little different withmicrosoft_peering_config
, it is only supported byMicrosoftPeering
. I add a check foripv6
notroute_filter_id
, if peering type is notMicrosoftPeering
andipv6
is configured, an error message will raise up.Check
ipv6
configure:https://github.com/xuzhang3/terraform-provider-azurerm/blob/f/expressroutecircuitpeering_enhance/azurerm/internal/services/network/express_route_circuit_peering_resource.go#L267