r/virtual_desktop_workspace_application_group_association: fixing import support #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes some bugs in the Data Share and Storage Sync data sources, where errors weren't raised |
jackofallops
approved these changes
Oct 29, 2020
azurerm/internal/services/desktopvirtualization/virtual_desktop_host_pool_resource_test.go
Outdated
Show resolved
Hide resolved
also locking based on the terraform type name rather than the azure type name for consistency with other resources
…g and adding an ID parser also fixes a bug during import where these values weren't available
…and locking to match the association resource
tombuildsstuff
force-pushed
the
r/virtual-desktop
branch
from
f9f9378 to
17bab2d
Compare
The data source itself is querying that for the data share, not it's schedules
tombuildsstuff
force-pushed
the
r/virtual-desktop
branch
from
c5a227e to
8dd6add
Compare
|
Desktop Virtualization tests pass:
|
|
Tests look good 👍 |
|
This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.35.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix for #9046 - but also spotted a couple of other issues whilst passing through to do fix that