-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_log_analytics_data_export_rule
#8995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WodansSon - aside from a few comments this LGTM 👍
@@ -1,5 +1,5 @@ | |||
--- | |||
subcategory: "Desktop Virtualization" | |||
subcategory: "DesktopVirtualization" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be changing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I got called out by the linter so I changed it to what was in the registration code... I'll switch it back to what it was originally. 😄
azurerm/internal/services/loganalytics/tests/log_analytics_data_export_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_data_export_resource.go
Outdated
Show resolved
Hide resolved
d.Set("export_rule_id", props.DataExportID) | ||
d.Set("destination_resource_id", flattenArmDataExportDestination(props.Destination)) | ||
d.Set("enabled", props.Enable) | ||
if tableNames := props.TableNames; tableNames != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the utility function checks for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, just looked... if it's nil
it returns an empty slice. 🙂
Co-authored-by: kt <[email protected]>
…a_export_resource_test.go Co-authored-by: kt <[email protected]>
…rt_resource.go Co-authored-by: kt <[email protected]>
This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.34.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.