New Resource: azurerm_eventgrid_system_topic

[jrauschenbusch]

Fix: #8293

New resource: azurerm_eventgrid_system_topic

make acctests SERVICE='eventgrid' TESTARGS='-run=TestAccAzureRMEventGridSystemTopic' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridSystemTopic -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMEventGridSystemTopic_basic
=== PAUSE TestAccAzureRMEventGridSystemTopic_basic
=== RUN   TestAccAzureRMEventGridSystemTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridSystemTopic_requiresImport
=== RUN   TestAccAzureRMEventGridSystemTopic_basicWithTags
=== PAUSE TestAccAzureRMEventGridSystemTopic_basicWithTags
=== CONT  TestAccAzureRMEventGridSystemTopic_basic
=== CONT  TestAccAzureRMEventGridSystemTopic_basicWithTags
=== CONT  TestAccAzureRMEventGridSystemTopic_requiresImport
--- PASS: TestAccAzureRMEventGridSystemTopic_basic (143.05s)
--- PASS: TestAccAzureRMEventGridSystemTopic_basicWithTags (143.06s)
--- PASS: TestAccAzureRMEventGridSystemTopic_requiresImport (148.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     151.809s

[katbyte]

Thanks for the PR @jrauschenbusch - overall this looks good but i've left some comments inline. In addition to them could we add some docs for this new resource? thanks!

[jrauschenbusch]

Thanks for the PR @jrauschenbusch - overall this looks good but i've left some comments inline. In addition to them could we add some docs for this new resource? thanks!

Hi @katbyte PR notes are fixed and docs are added

[tombuildsstuff]

hey @jrauschenbusch

Thanks for pushing those changes - I've taken a look through and left a few comments inline but if we can fix those up then this otherwise LGTM 👍

Thanks!

[jrauschenbusch]

@tombuildsstuff There are 2 open PR notes left. How should we proceed with them?

[jrauschenbusch]

@tombuildsstuff Applied last fixes. Ready to get merged if tests succeed. Ready for your final review.

[jackofallops]

After reviewing previous comments and the latest fixes, this LGTM 👍

Resolved comments

[jackofallops]

Tests passing:

[ghost]

This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!