New resource azurerm_mssql_server_extended_auditing_policy
#8447
Conversation
There was a problem hiding this comment.
Hey @yupwei68, this is looking good but I'm seeing issues with TestAccAzureRMMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall. Terraform wants to update storage_endpoint.
storage_endpoint: "" => "https://unlikely23exst2acctaae1z.blob.core.windows.net/"
It looks like we'll want to wait for a specific state as the resource goes down when updating the storage_endpoint.
"state": "Disabled",
"storageEndpoint": "",
and then comes back up later down the line
"state": "Enabled",
"storageEndpoint": "faketesturl",
Terraform doesn't catch it though so we should add a WaitforState and make sure the resource is Enabled before passing it on to the read method.
|
@mbfrahry Sorry, I forgot the server auditing creation is async, I'll change it. |
|
@mbfrahry Thanks for your comments. I've retested them. Please continue reviewing === RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_basic Process finished with exit code 0 |
|
This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.28.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Extend: #7793
Fix: #7486
#6906
#8437
=== RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_basic
=== PAUSE TestAccAzureRMMsSqlServerExtendedAuditingPolicy_basic
=== CONT TestAccAzureRMMsSqlServerExtendedAuditingPolicy_basic
--- PASS: TestAccAzureRMMsSqlServerExtendedAuditingPolicy_basic (195.94s)
=== RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_requiresImport
=== PAUSE TestAccAzureRMMsSqlServerExtendedAuditingPolicy_requiresImport
=== CONT TestAccAzureRMMsSqlServerExtendedAuditingPolicy_requiresImport
--- PASS: TestAccAzureRMMsSqlServerExtendedAuditingPolicy_requiresImport (244.87s)
=== RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_complete
=== PAUSE TestAccAzureRMMsSqlServerExtendedAuditingPolicy_complete
=== CONT TestAccAzureRMMsSqlServerExtendedAuditingPolicy_complete
--- PASS: TestAccAzureRMMsSqlServerExtendedAuditingPolicy_complete (175.96s)
=== RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_update
=== PAUSE TestAccAzureRMMsSqlServerExtendedAuditingPolicy_update
=== CONT TestAccAzureRMMsSqlServerExtendedAuditingPolicy_update
--- PASS: TestAccAzureRMMsSqlServerExtendedAuditingPolicy_update (280.84s)
=== RUN TestAccAzureRMMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall
=== PAUSE TestAccAzureRMMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall
=== CONT TestAccAzureRMMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall
--- PASS: TestAccAzureRMMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall (290.78s)
PASS
Process finished with exit code 0