Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_dns_x_record: ignore case on target_resource_id #8218

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 24, 2020

In some case (at least for the cdn endpoint), the ID of target resource
read from API (which uses the API model of the target resource) doesn't match
the target_resource_id if it is imported via Terraform (which actually
uses the API model of the azurerm_dns_x_record) in casing.

Fixes: #8191

In some case (at least for the cdn endpoint), the ID of target resource
read from API (which uses the API model of the target resource) doesn't match
the `target_resource_id` if it is imported via Terraform (which actually
uses the API model of the `azurerm_dns_x_record`) in casing.

Fixes: hashicorp#8191
@ghost ghost added the size/S label Aug 24, 2020
@tombuildsstuff
Copy link
Contributor

@magodo is there an Swagger bug to track this API bug?

ARM API's are supposed to be following Postel's law, where they are liberal in what they accept (eg uri's could be case insensitive) but conservative in what they send (eg case sensitive) - so this is a bug in the API which needs to be fixed

Whilst applying a DiffSuppress does work around this - it's something that we should avoid unless absolutely necessary, so it'd be worth raising the API bug here

@dossy
Copy link

dossy commented Aug 24, 2020

@tombuildsstuff, @magodo - I'm not familiar enough with TF's code (yet), but I feel like the issue is actually with azurerm_cdn_endpoint's id output not properly casing resourcegroups as resourceGroups.

@ghost ghost removed the waiting-response label Aug 24, 2020
@magodo
Copy link
Collaborator Author

magodo commented Aug 25, 2020

Close in favor of #8237, which modify the resource id of cdn endpoint.

@magodo magodo closed this Aug 25, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_dns_a_record failing with weird "from no visitor picked" string in target_resource_id?
3 participants