azurerm_kubernetes_cluster - Updates no longer fail when using managed AAD integration

[aristosvo]

Fixes #7325

Acceptance Tests:

make acctests SERVICE='containers' TESTARGS='-run=TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -run=TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD
=== PAUSE TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD
=== RUN   TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADUpdateToManaged
=== PAUSE TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADUpdateToManaged
=== RUN   TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManaged
=== PAUSE TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManaged
=== RUN   TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManagedChange
=== PAUSE TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManagedChange
=== CONT  TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD
=== CONT  TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManagedChange
=== CONT  TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManaged
=== CONT  TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADUpdateToManaged
--- PASS: TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManaged (720.09s)
--- PASS: TestAccAzureRMKubernetesCluster_roleBasedAccessControlAAD (776.63s)
--- PASS: TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADUpdateToManaged (853.89s)
--- PASS: TestAccAzureRMKubernetesCluster_roleBasedAccessControlAADManagedChange (979.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests      981.018s

[mbfrahry]

Hey @aristosvo, these changes seem sane but we should add some nil checks and a test to confirm it works!

[aristosvo]

Hey @aristosvo, these changes seem sane but we should add some nil checks and a test to confirm it works!

I've added nil checks and updated the acceptance tests to confirm that the following scenario's are working:

• Update from AAD-v1 to AAD-v2/Managed
• Node pool change with AAD-v2/Managed

[mbfrahry]

LGTM!

[ghost]

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!