Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect validatefunc on azurerm_policy_remediation #7600

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Remove incorrect validatefunc on azurerm_policy_remediation #7600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7532682
Remove incorrect validatefunc
matt-FFFFFF Jul 6, 2020
d0f7464
Clarify documentation
matt-FFFFFF Jul 6, 2020
5175064
Further clarify docs
matt-FFFFFF Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions azurerm/internal/services/policy/policy_remediation_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ func resourceArmPolicyRemediation() *schema.Resource {
Optional: true,
// TODO: remove this suppression when github issue https://github.com/Azure/azure-rest-api-specs/issues/8353 is addressed
DiffSuppressFunc: suppress.CaseDifference,
// TODO: use the validation function in azurerm_policy_definition when implemented
ValidateFunc: validate.PolicyDefinitionID,
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/policy_remediation.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ The following arguments are supported:

* `policy_assignment_id` - (Required) The resource ID of the policy assignment that should be remediated.

* `policy_definition_reference_id` - (Optional) The policy definition reference ID of the individual definition that should be remediated. Required when the policy assignment being remediated assigns a policy set definition.
* `policy_definition_reference_id` - (Optional) The unique ID for the policy definition within the policy set definition that should be remediated. Required when the policy assignment being remediated assigns a policy set definition.

* `location_filters` - (Optional) A list of the resource locations that will be remediated.

Expand Down