Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating to v43.1.0 of github.com/Azure/azure-sdk-for-go #7188

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff added this to the v2.13.0 milestone Jun 3, 2020
@tombuildsstuff tombuildsstuff requested a review from a team June 3, 2020 10:45
@ghost ghost added the size/XXL label Jun 3, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff modified the milestones: v2.13.0, v2.14.0 Jun 3, 2020
@jrauschenbusch
Copy link
Contributor

@tombuildsstuff When this PR is getting merged? I would like to use it to proceed with the Kusto SDK Upgrade and i do have a set of separate branches ready to extend the Kusto resources with some features (e.g. #6854, #6855)

@ArcturusZhang
Copy link
Contributor

Could we hold this for a while since I will include keyvault 2019-09-01 in the v43.1.0? I believe it could be released in at most the next a few days...

@katbyte
Copy link
Collaborator

katbyte commented Jun 9, 2020

@jrauschenbusch - i think we'll be merging this within the next couple of days

@jrauschenbusch
Copy link
Contributor

@tombuildsstuff @katbyte https://github.com/Azure/azure-sdk-for-go/releases/tag/v43.1.0 is now released. So imho there is no blocker anymore to get this PR updated and merged.

@tombuildsstuff
Copy link
Contributor Author

👋 from our side we'll look to update/merge this once 2.14 has been released later today 👍

@tombuildsstuff tombuildsstuff modified the milestones: v2.14.0, v2.15.0 Jun 11, 2020
@tombuildsstuff tombuildsstuff changed the title dependencies: updating to v43.0.0 of github.com/Azure/azure-sdk-for-go dependencies: updating to v43.1.0 of github.com/Azure/azure-sdk-for-go Jun 11, 2020
@tombuildsstuff tombuildsstuff merged commit 90f9cbd into master Jun 11, 2020
@tombuildsstuff tombuildsstuff deleted the deps/azure-sdk-v43 branch June 11, 2020 15:43
tombuildsstuff added a commit that referenced this pull request Jun 11, 2020
katbyte added a commit that referenced this pull request Jun 18, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants