Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/datasource azurerm_data_share_dataset #7064

Closed
wants to merge 7 commits into from

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 25, 2020

Partially fix #6480
resources:
azurerm_data_share_dataset_blob_storage
datashare dataset blob storage

azurerm_data_share_dataset_data_lake_gen1
datashare dataset gen1

azurerm_data_share_dataset_data_lake_gen2
datashare dataset gen2

azurerm_data_share_dataset_kusto_cluster
datashare dataset kusto

azurerm_data_share_dataset_kusto_database
datashare dataset kusto db

data source:
azurerm_data_share_dataset_blob_storage
datashare dataset blob storage datasource

azurerm_data_share_dataset_data_lake_gen1
datashare dataset gen1 datasource

azurerm_data_share_dataset_data_lake_gen2
datashare dataset gen2 datasource

azurerm_data_share_dataset_kusto_cluster
datashare dataset kusto datasource

azurerm_data_share_dataset_kusto_database
datashare dataset kusto db datasource

yupwei68 added 2 commits May 25, 2020 11:11
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 - given this is a 4,000 line PR could we just add these resource/datasource pairs one per PR to make this a little easier to review/not having to point out any issues multiple times? thanks!

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
@yupwei68 yupwei68 deleted the wyp-datashare-dataset branch June 7, 2021 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [Data Share]
2 participants