Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test config in api_management_logger_resource_test #6972

Merged
merged 2 commits into from
May 18, 2020

Conversation

lrxtom2
Copy link
Contributor

@lrxtom2 lrxtom2 commented May 18, 2020

Manual test passed without result information.

@ghost ghost added the size/XS label May 18, 2020
@lrxtom2
Copy link
Contributor Author

lrxtom2 commented May 18, 2020

go test -v .\tests -timeout 0 -run TestAccAzureRMApiManagementLogger_basicApplicationInsights
=== RUN TestAccAzureRMApiManagementLogger_basicApplicationInsights
=== PAUSE TestAccAzureRMApiManagementLogger_basicApplicationInsights
=== CONT TestAccAzureRMApiManagementLogger_basicApplicationInsights
--- PASS: TestAccAzureRMApiManagementLogger_basicApplicationInsights (2355.81s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests 2355.978s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @lrxtom2

@tombuildsstuff tombuildsstuff added this to the v2.11.0 milestone May 18, 2020
@tombuildsstuff tombuildsstuff merged commit 99e1ec1 into hashicorp:master May 18, 2020
@lrxtom2 lrxtom2 deleted the api_logger_fix branch May 19, 2020 09:25
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants