add traffic_selector_policy block and tests #6586
Conversation
There was a problem hiding this comment.
Hey @carloVentrella, thanks for the pr. Overall this looks good but could we update the docs? thanks!
azurerm/internal/services/network/data_source_virtual_network_gateway_connection.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_virtual_network_gateway_connection.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_virtual_network_gateway_connection.go
Outdated
Show resolved
Hide resolved
carloVentrella
force-pushed
the
f/traffic-selector-policy
branch
from
df1c8e8 to
77579e3
Compare
|
@katbyte I integrated your suggestions. Thanks |
|
@katbyte is it possible to merge this for the next release? |
There was a problem hiding this comment.
hey @carloVentrella
Thanks for pushing those changes - apologies for the delayed re-review here!
I've taken a look through and left some comments inline but this is off to a good start - if we can fix up the comments (and the tests pass) then this should otherwise be good to merge 👍
Thanks!
azurerm/internal/services/network/tests/virtual_network_gateway_connection_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
carloVentrella
force-pushed
the
f/traffic-selector-policy
branch
from
3da1d86 to
64cb8aa
Compare
This reverts commit 8ef39c0.
|
@carloVentrella thanks for the changes. this LGTM, just waiting on test results. |
|
Tests pass (1 race condition passed 2nd time):
|
|
This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.19.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #6272