Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - move the ID parsing function of VM, VM extension, VMSS, VMSS extension to the parse directory #6405

Merged

Conversation

ArcturusZhang
Copy link
Contributor

And azurerm_managed_disk is now using its ID parsing function

@ghost ghost added the size/XL label Apr 8, 2020
@ArcturusZhang ArcturusZhang force-pushed the Refine-VM-ID-parse-functions branch from 479f4ed to 38a9694 Compare April 8, 2020 13:32
@ArcturusZhang ArcturusZhang force-pushed the Refine-VM-ID-parse-functions branch from 24a244b to 48a2e32 Compare April 9, 2020 03:54
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ArcturusZhang! LGTM 👍

@katbyte katbyte merged commit 18e516b into hashicorp:master Apr 9, 2020
@ArcturusZhang ArcturusZhang deleted the Refine-VM-ID-parse-functions branch April 10, 2020 03:24
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants