Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: exposing the resource_manager_id field #6170

Merged
merged 4 commits into from
Mar 19, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This PR exposes the Resource Manager ID field since certain Storage Resources can be managed/referenced via either the Data Plane or Resource Manager API's

  • Data Source azurerm_storage_container - exposing the resource_manager_id field
  • azurerm_storage_container - exposing the resource_manager_id field
  • azurerm_storage_share - exposing the resource_manager_id field

Dependent on #6169
Fixes #4442

@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 19, 2020
@tombuildsstuff tombuildsstuff requested a review from a team March 19, 2020 08:52
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the f/storage-resource-id branch from c0f8ed2 to 759b1cd Compare March 19, 2020 10:42
@tombuildsstuff tombuildsstuff force-pushed the f/storage-resource-id branch from 759b1cd to 98a6af4 Compare March 19, 2020 12:31
@ghost ghost added size/S and removed size/M labels Mar 19, 2020
@tombuildsstuff tombuildsstuff merged commit cd88350 into master Mar 19, 2020
@tombuildsstuff tombuildsstuff deleted the f/storage-resource-id branch March 19, 2020 15:30
tombuildsstuff added a commit that referenced this pull request Mar 19, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing the Resource Manager ID for Storage Resources
2 participants