-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_function_app
- support for daily_memory_time_quota
#6100
azurerm_function_app
- support for daily_memory_time_quota
#6100
Conversation
"daily_memory_time_quota": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like if the value of DailyMemoryTimeQuota
is set to 0 or a negative value, then the quota will be turned off. I know schema.TypeInt
will default to a value of 0 if not provided. Do we want to explicitly set a default value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be fine - since the quota itself only affects functions inside a consumption plan?
…form-provider-azurerm into azurerm_function_app_daily_memory_time_quota
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
"daily_memory_time_quota": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be fine - since the quota itself only affects functions inside a consumption plan?
Ignoring a couple of known test errors (and the linting errors fixed in #6118) this otherwise LGTM: |
This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.2.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes: #6076
Adds the
daily_memory_time_quota
option to theazurerm_function_app
resource.