Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource/data source: azurerm_mssql_database #6083

Merged
merged 35 commits into from
Mar 25, 2020
Merged

New resource/data source: azurerm_mssql_database #6083

merged 35 commits into from
Mar 25, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Mar 12, 2020 •
edited by jackofallops
Loading

fixes #2849
fixes #3978
fixes #1126
addresses #4185

mssql db pass

@jackofallops jackofallops self-assigned this Mar 12, 2020
jackofallops
jackofallops requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68
Looking really good now. Just a few further minor changes needed (I missed something on the previous review, sorry).
Additionally, if you know the (current) default values for the optional parameters, could you add them to the resource documentation where appropriate please? It's really helpful for users.
Thanks!

azurerm/internal/services/mssql/parse/mssql.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated
Optional: true,
Computed: true,
ForceNew: true,
ValidateFunc: validation.StringMatch(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was marked resolved in error? (not using your new validate.MsSqlDBCollation) ?

azurerm/internal/services/mssql/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
website/docs/d/sql_server.html.markdown Outdated Show resolved Hide resolved
@jackofallops jackofallops added this to the v2.3.0 milestone Mar 19, 2020
@yupwei68 yupwei68 requested a review from jackofallops March 20, 2020 06:15
@yupwei68
Copy link
Contributor Author

Hi @jackofallops Sorry for the errors made. And thanks for your comments. Corresponding changes are made. Please continue your review.

jackofallops
jackofallops requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68
Just a few minor comments to address and I think this will be good to merge.

Thanks!

azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/validate/mssql_database.go Show resolved Hide resolved
website/docs/r/mssql_database.html.markdown Outdated Show resolved Hide resolved
website/docs/r/mssql_database.html.markdown Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Hi @jackofallops Thanks for the comments. Corresponding changes are updated, except one unresolved comment. Looking forward to get merged, too.

katbyte
katbyte requested changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes @yupwei68,

I've left some mostly minor comments inline, once these are addressed this should be good to merge!

azurerm/internal/services/mssql/data_source_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/data_source_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/data_source_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/tests/data_source_mssql_database_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/tests/resource_arm_mssql_database_test.go Outdated Show resolved Hide resolved
website/docs/r/mssql_database.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/validate/mssql_database.go Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Hi @katbyte , Thanks for your review comments. Corresponding changes are updated. All tests have been retested with pass.

@ghost ghost removed the waiting-response label Mar 24, 2020
katbyte
katbyte requested changes Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @yupwei68, just a couple more things and this should be good to merge 🙂

azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/resource_arm_mssql_database.go Outdated Show resolved Hide resolved
website/docs/d/mssql_database.html.markdown Show resolved Hide resolved
website/docs/d/mssql_database.html.markdown Show resolved Hide resolved
website/docs/d/mssql_database.html.markdown Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Hi @katbyte ,Sure! Thanks. Please continue your review.

@ghost ghost removed the waiting-response label Mar 25, 2020
@yupwei68 yupwei68 requested a review from katbyte March 25, 2020 05:20
katbyte
katbyte approved these changes Mar 25, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @yupwei68! LGTM now 👍

@katbyte katbyte merged commit 7d22b24 into hashicorp:master Mar 25, 2020
katbyte added a commit that referenced this pull request Mar 25, 2020
@katbyte
update CHANGELOG.md to include #6083
77cb292
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 26, 2020
Closed
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-sqldb-vscore branch March 30, 2020 01:22
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees

@jackofallops jackofallops

Labels
documentation new-data-source new-resource service/mssql Microsoft SQL Server size/XXL
Projects
None yet
Milestone
v2.3.0
3 participants
@yupwei68 @katbyte @jackofallops