Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventhub Throughput Unit Increase #556

Merged
merged 5 commits into from
Nov 15, 2017
Merged

Eventhub Throughput Unit Increase #556

merged 5 commits into from
Nov 15, 2017

Conversation

mocofound
Copy link

Pull request for enhancement to match validation with the documentation for Event Hub Capacity (Throughput Units).

Official Request:
azurerm_eventhub_namespace resource #361

Old Values: 1,2,4 for Basic and Standard SKUs.
New Values: 1-20 inclusive for Basic and Standard SKUs.

Azure Documentation:
https://azure.microsoft.com/en-us/pricing/details/event-hubs/

Harness Alex added 5 commits November 13, 2017 19:20
update azurerm_eventhub_namespace resource #361
Updating test cases to check for values greater than 0 and less than or equal to 20
Throughput Unit of 3 is within 1 - 20 inclusive therefore test case should now pass instead of fail.
Storage Account needed to be updated for account_type and account_tier
account_replication_type was misspelled
@mocofound
Copy link
Author

#506 Updated the HTML.Markdown for container_group documentation for the storage_account required parameters.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mocofound

Thanks for this PR - I've taken a look through and this LGTM :)

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

screen shot 2017-11-15 at 15 07 37

@tombuildsstuff tombuildsstuff merged commit edad641 into hashicorp:master Nov 15, 2017
tombuildsstuff added a commit that referenced this pull request Nov 15, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants