Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mysql_server: deprecate sku in favour of sku_name #5377

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 12, 2020

partially addresses #1500

@katbyte katbyte added this to the v1.41.0 milestone Jan 12, 2020
@katbyte katbyte requested a review from a team January 12, 2020 21:43
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise, LGTM!

@@ -339,6 +339,10 @@ This resource has been renamed to `azurerm_log_analytics_linked_service` which i

The deprecated field `linked_service_properties` will be removed. This has been replaced by the `resource_id` resource.

### Resource: `azurerm_mysql_server`

The deprecated `sku` block has been simplified and replaced by the `sku_name` property and will be removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The deprecated `sku` block has been simplified and replaced by the `sku_name` property and will be removed.
The deprecated `sku` block has been replaced by the `sku_name` field and will be removed.
The `sku_name` field will become Required.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte thanks for the help! LGTM! 🚀

@katbyte katbyte merged commit d01ca4a into master Jan 14, 2020
@katbyte katbyte deleted the kt/flatsku-mysql branch January 14, 2020 18:22
katbyte added a commit that referenced this pull request Jan 14, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants