New Resource: azurerm_api_management_identity_provider_aad
#5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Dec 28, 2019
| "client_id": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validate.NoEmptyStrings, |
There was a problem hiding this comment.
could we validate this is a guid (there is a existing function)
...ernal/services/apimanagement/tests/resource_arm_api_management_identity_provider_aad_test.go
Outdated
Show resolved
Hide resolved
| resource "azurerm_api_management_identity_provider_aad" "test" { | ||
| resource_group_name = "${azurerm_resource_group.test.name}" | ||
| api_management_name = "${azurerm_api_management.test.name}" | ||
| client_id = "aadclientid" |
There was a problem hiding this comment.
I think client IDs are guids??
...ernal/services/apimanagement/tests/resource_arm_api_management_identity_provider_aad_test.go
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aad.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aad.html.markdown
Outdated
Show resolved
Hide resolved
| resource "azurerm_api_management_identity_provider_aad" "test" { | ||
| resource_group_name = "${azurerm_resource_group.test.name}" | ||
| api_management_name = "${azurerm_api_management.test.name}" | ||
| client_id = "aadclientid" |
There was a problem hiding this comment.
And a guid here? (i could be wrong about this)
website/docs/r/api_management_identity_provider_aad.html.markdown
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/resource_arm_api_management_identity_provider_aad.go
Show resolved
Hide resolved
Co-Authored-By: kt <[email protected]>
…identity_provider_aad
|
@katbyte thanks for the review! updated the PR based on your comments. |
katbyte
added a commit
that referenced
this pull request
Dec 30, 2019
aqche
deleted the
resource_azurerm_api_management_identity_provider_aad
branch
jackbatzner
pushed a commit
to jackbatzner/terraform-provider-azurerm
that referenced
this pull request
Dec 31, 2019
…rp#5268) Partially addresses: hashicorp#5044 Adds the azurerm_api_management_identity_provider_aad resource.
jackbatzner
pushed a commit
to jackbatzner/terraform-provider-azurerm
that referenced
this pull request
Dec 31, 2019
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #5044
Adds the
azurerm_api_management_identity_provider_aadresource.