Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_app_configuration #4859

Merged
merged 23 commits into from
Dec 10, 2019
Merged

New Resource: azurerm_app_configuration #4859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e1ada85
add resource azurerm_app_configuration
brennerm Nov 6, 2019
d3fd5b9
add appconfiguration dependency
brennerm Nov 12, 2019
053b7e2
fix error handling in deletion method
brennerm Nov 12, 2019
7d1d6c4
adjust fetching of access keys
brennerm Nov 12, 2019
605e96e
remove unused variable
brennerm Nov 12, 2019
02194f6
fix log statement
brennerm Nov 13, 2019
2a9a681
use create instead of create/update timeout
brennerm Nov 13, 2019
5c7d877
align future handling in deletion method
brennerm Nov 13, 2019
5807463
add missing nil check
brennerm Nov 13, 2019
eea91fb
make access key of schema type list
brennerm Nov 15, 2019
bf3b4d9
add app_configuration resource doc
brennerm Nov 18, 2019
242024e
add tests for app_configuration resource
brennerm Nov 19, 2019
f7b4ebf
add app configuration to new client struct
brennerm Nov 19, 2019
423a277
add hint about SKU downgrade
brennerm Nov 20, 2019
60eb5c4
extract sku name in read method
brennerm Nov 28, 2019
3393355
Merge branch 'add-app-configuration-resource' of https://github.com/b…
mbfrahry Dec 2, 2019
ea7d0fb
remove MaxItems from access key fields
brennerm Dec 5, 2019
5a12c39
fix APIKey nil check
brennerm Dec 5, 2019
41fe134
remove SchemaVersion
brennerm Dec 5, 2019
222a017
Merge branch 'add-app-configuration-resource' of https://github.com/b…
mbfrahry Dec 9, 2019
bf7fb13
Merge with master
mbfrahry Dec 9, 2019
f26fcb7
Updating with master and fixing nil check
mbfrahry Dec 9, 2019
2fecf7a
Merge pull request #1 from terraform-providers/brennerm-add-app-confi…
brennerm Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions azurerm/internal/clients/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common"
analysisServices "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/analysisservices/client"
apiManagement "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/client"
appConfiguration "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/client"
applicationInsights "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/applicationinsights/client"
authorization "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/authorization/client"
automation "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/automation/client"
Expand Down Expand Up @@ -74,6 +75,7 @@ type Client struct {

AnalysisServices *analysisServices.Client
ApiManagement *apiManagement.Client
AppConfiguration *appConfiguration.Client
AppInsights *applicationInsights.Client
Authorization *authorization.Client
Automation *automation.Client
Expand Down Expand Up @@ -145,6 +147,7 @@ type Client struct {
func (client *Client) Build(o *common.ClientOptions) error {
client.AnalysisServices = analysisServices.NewClient(o)
client.ApiManagement = apiManagement.NewClient(o)
client.AppConfiguration = appConfiguration.NewClient(o)
client.AppInsights = applicationInsights.NewClient(o)
client.Authorization = authorization.NewClient(o)
client.Automation = automation.NewClient(o)
Expand Down
19 changes: 19 additions & 0 deletions azurerm/internal/services/appconfiguration/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package client

import (
appconf "github.com/Azure/azure-sdk-for-go/services/appconfiguration/mgmt/2019-10-01/appconfiguration"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common"
)

type Client struct {
AppConfigurationsClient *appconf.ConfigurationStoresClient
}

func NewClient(o *common.ClientOptions) *Client {
AppConfigurationsClient := appconf.NewConfigurationStoresClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&AppConfigurationsClient.Client, o.ResourceManagerAuthorizer)

return &Client{
AppConfigurationsClient: &AppConfigurationsClient,
}
}
1 change: 1 addition & 0 deletions azurerm/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ func Provider() terraform.ResourceProvider {
"azurerm_api_management_property": resourceArmApiManagementProperty(),
"azurerm_api_management_subscription": resourceArmApiManagementSubscription(),
"azurerm_api_management_user": resourceArmApiManagementUser(),
"azurerm_app_configuration": resourceArmAppConfiguration(),
"azurerm_app_service_active_slot": resourceArmAppServiceActiveSlot(),
"azurerm_app_service_certificate": resourceArmAppServiceCertificate(),
"azurerm_app_service_certificate_order": resourceArmAppServiceCertificateOrder(),
Expand Down
Loading