Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_account: Fix Advanced Threat Protection matching for Azure Germany #4746

Merged

Conversation

sigv
Copy link
Contributor

@sigv sigv commented Oct 29, 2019

Although the error message returned from Azure Germany Cloud is precisely "The resource namespace 'Microsoft.Security' is invalid." the error message we are seeing in r/storage_account has other contents added on it, so we cannot do an equals check directly. The ATP fix was being pushed as v1.36.0, but this change provides the actual resolution.

Ref #4563, #4564.

Although the error message returned from Azure Germany Cloud is
precisely "The resource namespace 'Microsoft.Security' is invalid."
the error message we are seeing in `r/storage_account` has other
contents added on it, so we cannot do an equals check directly.
The ATP fix was being pushed as v1.36.0, but this change provides
the actual resolution.

Ref hashicorp#4563, hashicorp#4564.
@ghost ghost added the size/XS label Oct 29, 2019
@sigv
Copy link
Contributor Author

sigv commented Oct 29, 2019

@katbyte Well, I did a bad assumption that msg was the same as debug log's Message -- as a result, v1.36.0 did not ship the fix for Azure Germany as in #4564. Properly tested this one locally and can run a terraform refresh.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sigv

Thanks for this PR - this LGTM 👍

FWIW we're going to move support for Advanced Threat Protection out into it's own resource in the near future, so whilst this will continue to be an issue until 2.0 of the Azure Provider is out - in the longer term this field will be in it's own resource and thus avoidable for most users.

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Oct 29, 2019
@tombuildsstuff tombuildsstuff merged commit adc4d47 into hashicorp:master Oct 29, 2019
tombuildsstuff added a commit that referenced this pull request Oct 29, 2019
@sigv sigv deleted the origin/storage_account-atp_germany2 branch October 29, 2019 15:09
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants