-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source/loadbalancer backend address pool/backend_ip_configurations to be computed #4625
Data source/loadbalancer backend address pool/backend_ip_configurations to be computed #4625
Conversation
marioanton
commented
Oct 15, 2019
- Adding compute to attribute backend_ip_configurations
- Minor lint issues
This PR is a fix for a bug my colleague found with the following PR which I raised a few days ago (#4605). It fixes this error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but we should remove the Optional: true
tag as well
@@ -33,6 +33,7 @@ func dataSourceArmLoadBalancerBackendAddressPool() *schema.Resource { | |||
"backend_ip_configurations": { | |||
Type: schema.TypeList, | |||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any attribute that isn't used to get the resource should remove the Required/Optional: true
tag in favor of Computed: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will sort that out.
Changes committed and tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing that
This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |