Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source/loadbalancer backend address pool/backend_ip_configurations to be computed #4625

Conversation

marioanton
Copy link
Contributor

  • Adding compute to attribute backend_ip_configurations
  • Minor lint issues

@ghost ghost added the size/XS label Oct 15, 2019
@marioanton marioanton changed the title Data source/loadbalancer backend address pool/computed Data source/loadbalancer backend address pool/backend_ip_configurations to be computed Oct 15, 2019
@leewilson86
Copy link
Contributor

@tombuildsstuff

This PR is a fix for a bug my colleague found with the following PR which I raised a few days ago (#4605).

It fixes this error:

Resource 'data.azurerm_lb_backend_address_pool.beap' does not have attribute 'backend_ip_configurations' for variable 'data.azurerm_lb_backend_address_pool.beap.backend_ip_configurations'

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but we should remove the Optional: true tag as well

@@ -33,6 +33,7 @@ func dataSourceArmLoadBalancerBackendAddressPool() *schema.Resource {
"backend_ip_configurations": {
Type: schema.TypeList,
Optional: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any attribute that isn't used to get the resource should remove the Required/Optional: true tag in favor of Computed: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will sort that out.

@marioanton
Copy link
Contributor Author

marioanton commented Oct 17, 2019

Changes committed and tested.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing that

@mbfrahry mbfrahry merged commit 58a76df into hashicorp:master Oct 17, 2019
@marioanton marioanton deleted the DataSource/LoadbalancerBackendAddressPool/Computed branch October 17, 2019 10:46
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants