Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable addon_profile for oms_agent (Fixes #4080) #4526

Closed
wants to merge 1 commit into from

Conversation

fxgsell
Copy link
Contributor

@fxgsell fxgsell commented Oct 5, 2019

Allows to disable oms_agent and aci_connector_linux by making log_analytics_workspace_id and subnet_name optional fields.

@katbyte
Copy link
Collaborator

katbyte commented Oct 5, 2019

Hi @fxgsell,

We have just merged #4513 which seems very similar to this PR and tackles the same issue. Could you check and see if it would fix the issue?

@fxgsell
Copy link
Contributor Author

fxgsell commented Oct 5, 2019

Ha thanks, I missed that one, it does fix #4080 as well, but not for the aci_connector_linux.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @fxgsell, for aci_connector_linux the subnet must be optional? is there an issue you can link to with the error (or create & update this PR to only fix that with a test?)

@katbyte
Copy link
Collaborator

katbyte commented Oct 8, 2019

Hi @fxgsell, We just merged #4541 which should fix this for you, as such i am going to close this.

@katbyte katbyte closed this Oct 8, 2019
@katbyte katbyte modified the milestone: v1.36.0 Oct 8, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants