New Resource: azurerm_private_link_endpoint New Data Source: azurerm_private_link_endpoint_connection and expose attibute in azurerm_subnet

azurerm/data_source_private_link_endpoint_connection.go

@@ -0,0 +1,186 @@
+package azurerm
+
+import (
+	"fmt"
+
+	"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2019-09-01/network"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
+	aznet "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
+)
+
+func dataSourceArmPrivateLinkEndpointConnection() *schema.Resource {
+	return &schema.Resource{
+		Read: dataSourceArmPrivateLinkEndpointConnectionRead,
+
+		Schema: map[string]*schema.Schema{
+			"name": {
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: aznet.ValidatePrivateLinkName,
+			},
+
+			"location": azure.SchemaLocationForDataSource(),
+
+			"resource_group_name": azure.SchemaResourceGroupNameForDataSource(),
+
+			"private_service_connection": {
+				Type:     schema.TypeList,
+				Computed: true,
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"name": {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
+						"request_response": {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
+						"status": {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
+						"private_ip_address": {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
+					},
+				},
+			},
+		},
+	}
+}
+
+func dataSourceArmPrivateLinkEndpointConnectionRead(d *schema.ResourceData, meta interface{}) error {
+	client := meta.(*ArmClient).Network.PrivateEndpointClient
+	ctx := meta.(*ArmClient).StopContext
+
+	name := d.Get("name").(string)
+	resourceGroup := d.Get("resource_group_name").(string)
+
+	resp, err := client.Get(ctx, resourceGroup, name, "")
+	if err != nil {
+		if utils.ResponseWasNotFound(resp.Response) {
+			d.SetId("")
+			return nil
+		}
+		return fmt.Errorf("Error reading Private Link Endpoint %q (Resource Group %q): %+v", name, resourceGroup, err)
+	}
+	if resp.ID == nil || *resp.ID == "" {
+		return fmt.Errorf("API returns a nil/empty id on Private Link Endpoint %q (Resource Group %q): %+v", name, resourceGroup, err)
+	}
+
+	d.SetId(*resp.ID)
+	d.Set("name", resp.Name)
+	d.Set("resource_group_name", resourceGroup)
+	if location := resp.Location; location != nil {
+		d.Set("location", azure.NormalizeLocation(*location))
+	}
+
+	if props := resp.PrivateEndpointProperties; props != nil {
+		privateIpAddress := ""
+
+		if nics := props.NetworkInterfaces; nics != nil && len(*nics) > 0 {
+			nic := (*nics)[0]
+			if nic.ID != nil && *(nic.ID) != "" {
+				privateIpAddress = getPrivateIpAddress(*(nic.ID), meta)
+			}
+		}
+
+		if err := d.Set("private_service_connection", dataSourceFlattenArmPrivateLinkEndpointServiceConnection(props.PrivateLinkServiceConnections, props.ManualPrivateLinkServiceConnections, privateIpAddress)); err != nil {
+			return fmt.Errorf("Error setting `private_service_connection`: %+v", err)
+		}
+	}
+
+	return nil
+}
+
+func getPrivateIpAddress(networkInterfaceId string, meta interface{}) string {
+	privateIpAddress := ""
+	id, err := azure.ParseAzureResourceID(networkInterfaceId)
+	if err != nil {
+		return privateIpAddress
+	}
+	name := id.Path["networkInterfaces"]
+
+	client := meta.(*ArmClient).Network.InterfacesClient
+	ctx := meta.(*ArmClient).StopContext
+
+	resp, err := client.Get(ctx, id.ResourceGroup, name, "")
+	if err != nil {
+		return privateIpAddress
+	}
+
+	if props := resp.InterfacePropertiesFormat; props != nil {
+		if configs := props.IPConfigurations; configs != nil {
+			for i, config := range *configs {
+				if propFmt := config.InterfaceIPConfigurationPropertiesFormat; propFmt != nil {
+					if propFmt.PrivateIPAddress != nil && *propFmt.PrivateIPAddress != "" && i == 0 {
+						privateIpAddress = *propFmt.PrivateIPAddress
+					}
+					break
+				}
+			}
+		}
+	}
+
+	return privateIpAddress
+}
+
+func dataSourceFlattenArmPrivateLinkEndpointServiceConnection(serviceConnections *[]network.PrivateLinkServiceConnection, manualServiceConnections *[]network.PrivateLinkServiceConnection, privateIpAddress string) []interface{} {
+	results := make([]interface{}, 0)
+	if serviceConnections == nil && manualServiceConnections == nil {
+		return results
+	}
+
+	if serviceConnections != nil {
+		for _, item := range *serviceConnections {
+			result := make(map[string]interface{})
+			result["private_ip_address"] = privateIpAddress
+
+			if v := item.Name; v != nil {
+				result["name"] = *v
+			}
+			if props := item.PrivateLinkServiceConnectionProperties; props != nil {
+				if v := props.PrivateLinkServiceConnectionState; v != nil {
+					if s := v.Status; s != nil {
+						result["status"] = *s
+					}
+					if d := v.Description; d != nil {
+						result["request_response"] = *d
+					}
+				}
+			}
+
+			results = append(results, result)
+		}
+	}
+
+	if manualServiceConnections != nil {
+		for _, item := range *manualServiceConnections {
+			result := make(map[string]interface{})
+			result["private_ip_address"] = privateIpAddress
+
+			if v := item.Name; v != nil {
+				result["name"] = *v
+			}
+			if props := item.PrivateLinkServiceConnectionProperties; props != nil {
+				if v := props.PrivateLinkServiceConnectionState; v != nil {
+					if s := v.Status; s != nil {
+						result["status"] = *s
+					}
+					if d := v.Description; d != nil {
+						result["request_response"] = *d
+					}
+				}
+			}
+
+			results = append(results, result)
+		}
+	}
+
+	return results
+}

azurerm/data_source_private_link_endpoint_connection_test.go

@@ -0,0 +1,39 @@
+package azurerm
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
+)
+
+func TestAccDataSourceAzureRMPrivateLinkEndpointConnection_complete(t *testing.T) {
+	dataSourceName := "data.azurerm_private_link_endpoint_connection.test"
+	ri := tf.AccRandTimeInt()
+	location := testLocation()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataSourcePrivateLinkEndpointConnection_complete(ri, location),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(dataSourceName, "private_service_connection.0.status", "Approved"),
+				),
+			},
+		},
+	})
+}
+
+func testAccDataSourcePrivateLinkEndpointConnection_complete(rInt int, location string) string {
+	return fmt.Sprintf(`
+%s
+
+data "azurerm_private_link_endpoint_connection" "test" {
+  name                = azurerm_private_link_endpoint.test.name
+  resource_group_name = azurerm_resource_group.test.name
+}
+`, testAccAzureRMPrivateEndpoint_basic(rInt, location))
+}

azurerm/data_source_private_link_service.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"time"
 
+	"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2019-09-01/network"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	aznet "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network"
@@ -24,25 +25,23 @@ func dataSourceArmPrivateLinkService() *schema.Resource {
 			"name": {
 				Type:         schema.TypeString,
 				Required:     true,
-				ValidateFunc: aznet.ValidatePrivateLinkServiceName,
+				ValidateFunc: aznet.ValidatePrivateLinkName,
 			},
 
 			"location": azure.SchemaLocationForDataSource(),
 
 			"resource_group_name": azure.SchemaResourceGroupNameForDataSource(),
 
 			"auto_approval_subscription_ids": {
-				Type:     schema.TypeSet,
+				Type:     schema.TypeList,
 				Computed: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
-				Set:      schema.HashString,
 			},
 
 			"visibility_subscription_ids": {
-				Type:     schema.TypeSet,
+				Type:     schema.TypeList,
 				Computed: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
-				Set:      schema.HashString,
 			},
 
 			// currently not implemented yet, timeline unknown, exact purpose unknown, maybe coming to a future API near you
@@ -85,10 +84,9 @@ func dataSourceArmPrivateLinkService() *schema.Resource {
 			},
 
 			"load_balancer_frontend_ip_configuration_ids": {
-				Type:     schema.TypeSet,
+				Type:     schema.TypeList,
 				Computed: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
-				Set:      schema.HashString,
 			},
 
 			"alias": {
@@ -97,10 +95,9 @@ func dataSourceArmPrivateLinkService() *schema.Resource {
 			},
 
 			"network_interface_ids": {
-				Type:     schema.TypeSet,
+				Type:     schema.TypeList,
 				Computed: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
-				Set:      schema.HashString,
 			},
 
 			"tags": tags.SchemaDataSource(),
@@ -155,12 +152,12 @@ func dataSourceArmPrivateLinkServiceRead(d *schema.ResourceData, meta interface{
 			}
 		}
 		if props.LoadBalancerFrontendIPConfigurations != nil {
-			if err := d.Set("load_balancer_frontend_ip_configuration_ids", flattenArmPrivateLinkServiceFrontendIPConfiguration(props.LoadBalancerFrontendIPConfigurations)); err != nil {
+			if err := d.Set("load_balancer_frontend_ip_configuration_ids", dataSourceFlattenArmPrivateLinkServiceFrontendIPConfiguration(props.LoadBalancerFrontendIPConfigurations)); err != nil {
 				return fmt.Errorf("Error setting `load_balancer_frontend_ip_configuration_ids`: %+v", err)
 			}
 		}
 		if props.NetworkInterfaces != nil {
-			if err := d.Set("network_interface_ids", flattenArmPrivateLinkServiceInterface(props.NetworkInterfaces)); err != nil {
+			if err := d.Set("network_interface_ids", dataSourceFlattenArmPrivateLinkServiceInterface(props.NetworkInterfaces)); err != nil {
 				return fmt.Errorf("Error setting `network_interface_ids`: %+v", err)
 			}
 		}
@@ -173,3 +170,33 @@ func dataSourceArmPrivateLinkServiceRead(d *schema.ResourceData, meta interface{
 
 	return tags.FlattenAndSet(d, resp.Tags)
 }
+
+func dataSourceFlattenArmPrivateLinkServiceFrontendIPConfiguration(input *[]network.FrontendIPConfiguration) []string {
+	results := make([]string, 0)
+	if input == nil {
+		return results
+	}
+
+	for _, item := range *input {
+		if id := item.ID; id != nil {
+			results = append(results, *id)
+		}
+	}
+
+	return results
+}
+
+func dataSourceFlattenArmPrivateLinkServiceInterface(input *[]network.Interface) []string {
+	results := make([]string, 0)
+	if input == nil {
+		return results
+	}
+
+	for _, item := range *input {
+		if id := item.ID; id != nil {
+			results = append(results, *id)
+		}
+	}
+
+	return results
+}