Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: data_factory_integration_runtime_managed #4342

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Sep 17, 2019

Requested and discussed here: #3275

@r0bnet r0bnet changed the title Resource data factory integration runtime managed New Resource: data_factory_integration_runtime_managed Sep 20, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @r0bnet. These changes look great! There are some missed errors and checks that we should do and I've called those out below.

@r0bnet
Copy link
Contributor Author

r0bnet commented Oct 2, 2019

Hey @r0bnet. These changes look great! There are some missed errors and checks that we should do and I've called those out below.

Fixed most of the stuff except two things: no import steps for catalog info and custom setup script tests as password or sas token is not returned via API so it differs from what is in the state.

@mbfrahry
Copy link
Member

mbfrahry commented Oct 2, 2019

You can throw in an ImportStateVerifyIgnore to ignore the fields that aren't returned from the API (i.e. ImportStateVerifyIgnore: []string{"catalog_info.0.administrator_password"},).

@r0bnet
Copy link
Contributor Author

r0bnet commented Oct 16, 2019

You can throw in an ImportStateVerifyIgnore to ignore the fields that aren't returned from the API (i.e. ImportStateVerifyIgnore: []string{"catalog_info.0.administrator_password"},).

Ah okay. Thanks. Fixed that for the two tests and it ran the tests locally. Seems to be fine now.

@ghost ghost removed the waiting-response label Oct 16, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up @r0bnet. Apologies for the rebasing you had to do

@mbfrahry mbfrahry merged commit 09ba9fb into hashicorp:master Oct 17, 2019
@r0bnet r0bnet deleted the resource_data_factory_integration_runtime_managed branch October 18, 2019 13:22
@muralidar44
Copy link

@r0bnet , I am looking for terraform code to create "Datafactory Azure-SSIS Integration runtime" , could you please help, where to get it.

@r0bnet
Copy link
Contributor Author

r0bnet commented Mar 11, 2020

Hey @muralidar44,

sure. Looking at the documentation there is already an up&running example.

@ghost
Copy link

ghost commented Mar 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants