-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_devspace_controller
Bump API version
#4288
Conversation
Fixes #3805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @nexxai,
however i believe we'll need to update to a newer version yet:
Error: Error creating DevSpace Controller "acctestdsc190910092438094212" (Resource Group "acctestRG-190910092438094212"): devspaces.ControllersClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2019-01-01-preview' for type 'controllers'. The supported api-versions are '2019-04-01'. The supported locations are 'eastus, canadaeast, westeurope, canadacentral, centralus, westus2, westcentralus, southeastasia, eastus2, northeurope, australiaeast, uksouth, southcentralus'."
@katbyte Sorry, I didn't even clue into the fact that I was still on the preview branch. Upgraded to 2019-04-01 (full public). |
Looks like there is a problem with the latest API version too:
😞 |
👋 Taking a quick look here - unfortunately I can't immediately find the API documentation for DevSpace, but I'm wondering if the |
Opened Azure/azure-sdk-for-go#5990 on the SDK to get more context into the issue |
hey @nexxai Taking a closer look into this it appears the Since fixing this is required to update the Azure SDK (which is a dependency for some other things we're working on) and this PR has conflicts (and for some reason doesn't show the origin repo/branch) - whilst I'd like to thank you for this contribution so that we can get this merged I'm going to close this PR in favour of a new one which updates the API version and makes this field user configurable - I hope you don't mind! Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixing after rebasing/reforking