Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_devspace_controller Bump API version #4288

Closed
wants to merge 2 commits into from
Closed

azurerm_devspace_controller Bump API version #4288

wants to merge 2 commits into from

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Sep 9, 2019

Fixing after rebasing/reforking

@nexxai
Copy link
Contributor Author

nexxai commented Sep 9, 2019

Fixes #3805

@katbyte katbyte added this to the v1.34.0 milestone Sep 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @nexxai,

however i believe we'll need to update to a newer version yet:

Error: Error creating DevSpace Controller "acctestdsc190910092438094212" (Resource Group "acctestRG-190910092438094212"): devspaces.ControllersClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2019-01-01-preview' for type 'controllers'. The supported api-versions are '2019-04-01'. The supported locations are 'eastus, canadaeast, westeurope, canadacentral, centralus, westus2, westcentralus, southeastasia, eastus2, northeurope, australiaeast, uksouth, southcentralus'."

@nexxai
Copy link
Contributor Author

nexxai commented Sep 10, 2019

@katbyte Sorry, I didn't even clue into the fact that I was still on the preview branch. Upgraded to 2019-04-01 (full public).

@katbyte
Copy link
Collaborator

katbyte commented Sep 12, 2019

Looks like there is a problem with the latest API version too:

testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: azurerm_devspace_controller.test
          data_plane_fqdn:                          "azds-d4a0111e-cb75-45e2-9b14-424a2874f154.weu.azds.io" => "<computed>"
          host_suffix:                              "rwxnnlkqxm.weu.azds.io" => "suffix" (forces new resource)

😞

@tombuildsstuff
Copy link
Contributor

👋

Taking a quick look here - unfortunately I can't immediately find the API documentation for DevSpace, but I'm wondering if the host_suffix field has become Computed in this latest API version, rather than being user-specifiable?

@katbyte
Copy link
Collaborator

katbyte commented Oct 10, 2019

Opened Azure/azure-sdk-for-go#5990 on the SDK to get more context into the issue

@katbyte katbyte added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Oct 10, 2019
@katbyte katbyte modified the milestones: v1.36.0, Blocked Oct 10, 2019
@tombuildsstuff
Copy link
Contributor

hey @nexxai

Taking a closer look into this it appears the host_suffix field is now configured by Azure rather than being user-configurable - as such we need to update the API version being used we need to make this field Computed (meaning we'll read the value from whatever Azure tells us) rather than user-configurable.

Since fixing this is required to update the Azure SDK (which is a dependency for some other things we're working on) and this PR has conflicts (and for some reason doesn't show the origin repo/branch) - whilst I'd like to thank you for this contribution so that we can get this merged I'm going to close this PR in favour of a new one which updates the API version and makes this field user configurable - I hope you don't mind!

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies service/devspace size/XXL upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR waiting-response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants