Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_account: gracefully degrading when there's a Write Lock or the user doesn't have permissions #4248

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

tombuildsstuff
Copy link
Contributor

When the user doesn't have permissions to access the ListKeys endpoint, either because the
Resource has a Write Lock (where ListKeys counts as a Write Operation, which is being tracked
in Azure/azure-rest-api-specs#6363) or because the user doesn't have
permissions - this now degrades these fields into empty values, rather than outright failing.

fixes #4138

…e user doesn't have permissions

When the user doesn't have permissions to access the ListKeys endpoint, either because the
Resource has a Write Lock (where ListKeys counts as a Write Operation, which is being tracked
in Azure/azure-rest-api-specs#6363) or because the user doesn't have
permissions - this now degrades these fields into empty values, rather than outright failing.

fixes #4138
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-09-05 at 11 27 20

@tombuildsstuff tombuildsstuff merged commit c17947a into master Sep 5, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-account-degredation branch September 5, 2019 09:28
tombuildsstuff added a commit that referenced this pull request Sep 5, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully degrade "List Account Keys" during plan phase
2 participants