Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_private_dns_zone_a_record #3849

Merged
merged 5 commits into from
Jul 17, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions azurerm/internal/services/privatedns/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ import (
)

type Client struct {
RecordSetsClient privatedns.RecordSetsClient
PrivateZonesClient privatedns.PrivateZonesClient
}

func BuildClient(o *common.ClientOptions) *Client {
c := Client{}

c.RecordSetsClient = privatedns.NewRecordSetsClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&c.RecordSetsClient.Client, o.ResourceManagerAuthorizer)

c.PrivateZonesClient = privatedns.NewPrivateZonesClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&c.PrivateZonesClient.Client, o.ResourceManagerAuthorizer)

Expand Down
1 change: 1 addition & 0 deletions azurerm/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ func Provider() terraform.ResourceProvider {
"azurerm_postgresql_server": resourceArmPostgreSQLServer(),
"azurerm_postgresql_virtual_network_rule": resourceArmPostgreSQLVirtualNetworkRule(),
"azurerm_private_dns_zone": resourceArmPrivateDnsZone(),
"azurerm_private_dns_a_record": resourceArmPrivateDnsARecord(),
"azurerm_public_ip": resourceArmPublicIp(),
"azurerm_public_ip_prefix": resourceArmPublicIpPrefix(),
"azurerm_recovery_services_protected_vm": resourceArmRecoveryServicesProtectedVm(),
Expand Down
188 changes: 188 additions & 0 deletions azurerm/resource_arm_private_dns_a_record.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
package azurerm

import (
"fmt"
"net/http"

"github.com/Azure/azure-sdk-for-go/services/privatedns/mgmt/2018-09-01/privatedns"
"github.com/hashicorp/terraform/helper/schema"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
)

func resourceArmPrivateDnsARecord() *schema.Resource {
return &schema.Resource{
Create: resourceArmPrivateDnsARecordCreateUpdate,
Read: resourceArmPrivateDnsARecordRead,
Update: resourceArmPrivateDnsARecordCreateUpdate,
Delete: resourceArmPrivateDnsARecordDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},

Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
},

"resource_group_name": azure.SchemaResourceGroupName(),
patst marked this conversation as resolved.
Show resolved Hide resolved

"zone_name": {
Type: schema.TypeString,
Required: true,
},

"records": {
Type: schema.TypeSet,
Required: true,
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
},

"ttl": {
Type: schema.TypeInt,
Required: true,
},

"tags": tagsSchema(),
},
}
}

func resourceArmPrivateDnsARecordCreateUpdate(d *schema.ResourceData, meta interface{}) error {
client := meta.(*ArmClient).privateDns.RecordSetsClient
ctx := meta.(*ArmClient).StopContext

name := d.Get("name").(string)
resGroup := d.Get("resource_group_name").(string)
zoneName := d.Get("zone_name").(string)

if requireResourcesToBeImported && d.IsNewResource() {
existing, err := client.Get(ctx, resGroup, zoneName, privatedns.A, name)
if err != nil {
if !utils.ResponseWasNotFound(existing.Response) {
return fmt.Errorf("Error checking for presence of existing Private DNS A Record %q (Private Zone %q / Resource Group %q): %s", name, zoneName, resGroup, err)
}
}

if existing.ID != nil && *existing.ID != "" {
return tf.ImportAsExistsError("azurerm_private_dns_a_record", *existing.ID)
}
}

ttl := int64(d.Get("ttl").(int))
tags := d.Get("tags").(map[string]interface{})

parameters := privatedns.RecordSet{
Name: &name,
RecordSetProperties: &privatedns.RecordSetProperties{
Metadata: expandTags(tags),
TTL: &ttl,
ARecords: expandAzureRmPrivateDnsARecords(d),
},
}

eTag := ""
ifNoneMatch := "" // set to empty to allow updates to records after creation
if _, err := client.CreateOrUpdate(ctx, resGroup, zoneName, privatedns.A, name, parameters, eTag, ifNoneMatch); err != nil {
return fmt.Errorf("Error creating/updating Private DNS A Record %q (Zone %q / Resource Group %q): %s", name, zoneName, resGroup, err)
}

resp, err := client.Get(ctx, resGroup, zoneName, privatedns.A, name)
if err != nil {
return fmt.Errorf("Error retrieving Private DNS A Record %q (Zone %q / Resource Group %q): %s", name, zoneName, resGroup, err)
}

if resp.ID == nil {
return fmt.Errorf("Cannot read Private DNS A Record %s (resource group %s) ID", name, resGroup)
}

d.SetId(*resp.ID)

return resourceArmPrivateDnsARecordRead(d, meta)
}

func resourceArmPrivateDnsARecordRead(d *schema.ResourceData, meta interface{}) error {
dnsClient := meta.(*ArmClient).privateDns.RecordSetsClient
ctx := meta.(*ArmClient).StopContext

id, err := parseAzureResourceID(d.Id())
if err != nil {
return err
}

resGroup := id.ResourceGroup
name := id.Path["A"]
zoneName := id.Path["privateDnsZones"]

resp, err := dnsClient.Get(ctx, resGroup, zoneName, privatedns.A, name)
if err != nil {
if utils.ResponseWasNotFound(resp.Response) {
d.SetId("")
return nil
}
return fmt.Errorf("Error reading Private DNS A record %s: %+v", name, err)
}

d.Set("name", name)
d.Set("resource_group_name", resGroup)
d.Set("zone_name", zoneName)
d.Set("ttl", resp.TTL)

if err := d.Set("records", flattenAzureRmPrivateDnsARecords(resp.ARecords)); err != nil {
return err
}
flattenAndSetTags(d, resp.Metadata)

return nil
}

func resourceArmPrivateDnsARecordDelete(d *schema.ResourceData, meta interface{}) error {
dnsClient := meta.(*ArmClient).privateDns.RecordSetsClient
ctx := meta.(*ArmClient).StopContext

id, err := parseAzureResourceID(d.Id())
if err != nil {
return err
}

resGroup := id.ResourceGroup
name := id.Path["A"]
zoneName := id.Path["privateDnsZones"]

resp, err := dnsClient.Delete(ctx, resGroup, zoneName, privatedns.A, name, "")
if resp.StatusCode != http.StatusOK {
return fmt.Errorf("Error deleting Private DNS A Record %s: %+v", name, err)
}

return nil
}

func flattenAzureRmPrivateDnsARecords(records *[]privatedns.ARecord) []string {
results := make([]string, 0, len(*records))
patst marked this conversation as resolved.
Show resolved Hide resolved

if records != nil {
for _, record := range *records {
results = append(results, *record.Ipv4Address)
tombuildsstuff marked this conversation as resolved.
Show resolved Hide resolved
}
}

return results
}

func expandAzureRmPrivateDnsARecords(d *schema.ResourceData) *[]privatedns.ARecord {
recordStrings := d.Get("records").(*schema.Set).List()
records := make([]privatedns.ARecord, len(recordStrings))

for i, v := range recordStrings {
ipv4 := v.(string)
records[i] = privatedns.ARecord{
Ipv4Address: &ipv4,
}
}

return &records
}
Loading