Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for azurerm_key_vault_access_policy #3733

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Fix documentation for azurerm_key_vault_access_policy #3733

merged 2 commits into from
Jun 26, 2019

Conversation

javisst
Copy link
Contributor

@javisst javisst commented Jun 26, 2019

Vault_name and resource_group_name was deprecated but documentation was not updated.

See changelog:

DEPRECATIONS

  • azurerm_key_vault_access_policy - deprecating the vault_name and resource_group_name properties in favour of key_vault_id (#2820)

#2820

- deprecating the vault_name and resource_group_name properties in favour of key_vault_id (#2820)
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @javisst!

LGTM 👍

@katbyte katbyte merged commit 437fc8b into hashicorp:master Jun 26, 2019
@katbyte katbyte added this to the v1.31.0 milestone Jun 26, 2019
@katbyte katbyte added the service/key-vault Key Vault label Jun 26, 2019
@javisst javisst deleted the fix-docu-access-policy branch June 27, 2019 06:11
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants