fix to allow multiple rule setup in the redis firewall resource

[andrey-dubnik]

At the moment Redis SDK return success when 2+ rules are being setup in the terraform configuration where in reality create operation does not create more than 1 rule returning success for all operations which results in the read error happening in the resourceArmRedisFirewallRuleCreateUpdate

module.redis_test.azurerm_redis_firewall_rule.hosting[1]: Creating...
module.redis_test.azurerm_redis_firewall_rule.hosting[0]: Creating...
module.redis_test.azurerm_redis_firewall_rule.hosting[0]: Creation complete after 3s [id=/subscriptions/89731d00-1ebf-435f-919e-45920d73b538/resourceGroups/rgpazewtmlit001tftest/providers/Microsoft.Cache/Redis/redis-stack-tst2/firewallRules/rule_0]

Error: redis.FirewallRulesClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="ResourceNotFound" Message="A requested resource could not be found. It may already have been deleted.\r\nRequestID=15c4d104-5eb2-48c5-9e99-1e00ad04ddab"

As a fix I've added a retry logic to the resourceArmRedisFirewallRuleCreateUpdate which will loop through the create process until all reads are successful or create operation fails.

(fixes #2830)

[andrey-dubnik]

#2830

[andrey-dubnik]

Works with tf.12 as well

[katbyte]

Hi @adubnik,

Thanks for this fix! the code LGTM, however could we ad a regression test with multiple firewall rules to ensure its not broken in the future? Once thats addthis this should be good to merge 🙂

[andrey-dubnik]

@katbyte I thought as much :) Added the multi rule test now

[katbyte]

Thanks for adding the test @adubnik, LGTM now!

[ghost]

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!