-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Load balancer to support PublicIPPrefix as frontendipconfiguration #3675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @NillsF
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can add the documentation for the two new fields this otherwise LGTM 👍
Thanks!
@tombuildsstuff : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @NillsF! LGTM & tests pass 👍
This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.31.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Reason for the pull request: It was not possible to create a outboundrule using a PublicIpPrefix, as the frontendipconfiguration in terraform didn't support PublicIpPrefix. This PR contains that fix, plus also a minor update to a regular load balancer rule to allow the
disableoutboundsnat
to be set on a load balancer rule.Major contribution: PublicIPPrefix as frontendIPConfiguration
I made changes to
azurerm\resource_arm_loadbalancer.go
to allow a PublicIPPrefix to be used for a frontendipconfiguration. I edited two test files to have the required tests to cover this:azurerm\resource_arm_loadbalancer_test.go
andazurerm\resource_arm_loadbalancer_outbound_rule_test.go
Minor contribution: enable disableoutboundsnat on a load balancer rule to be set from Terraform.
I made changes to
azurerm\resource_arm_loadbalancer_rule.go
to allow thedisableoutboundsnat
parameter to be set. I also edited the test file for load balancer rule to have a new test scenario for these rulesazurerm\resource_arm_loadbalancer_test.go
.