Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading the Security API to 2017-08-01-preview #3269

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Which works around a breaking change in the API, introduced when #3126 was introduced:

=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace/update
--- FAIL: TestAccAzureRMSecurityCenter_pricingAndWorkspace (296.60s)
    --- FAIL: TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing (4.80s)
        --- FAIL: TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing/update (4.80s)
            testing.go:538: Step 0 error: Error applying: 1 error occurred:
                    * azurerm_security_center_subscription_pricing.test: 1 error occurred:
                    * azurerm_security_center_subscription_pricing.test: Error creating/updating Security Center Subscription pricing: security.PricingsClient#Update: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidResourceName" Message="The name 'default' is not a valid name. Possible pricing bundle names: VirtualMachines, SqlServers, AppServices, StorageAccounts."

@tombuildsstuff tombuildsstuff requested a review from a team April 17, 2019 05:57
@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 50757f9 into master Apr 17, 2019
@tombuildsstuff tombuildsstuff deleted the b/security-pricing branch April 17, 2019 10:11
tombuildsstuff added a commit that referenced this pull request Apr 17, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants