-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_data_factory_linked_service_sql_server
#3205
Conversation
I'll review this once #3159 is merged and the diff is a tad cleaner |
@katbyte, this should look a bit cleaner now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mbfrahry
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments this should otherwise be good to merge 👍
Thanks!
website/docs/r/data_factory_linked_service_sql_server.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_linked_service_sql_server.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_linked_service_sql_server.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_linked_service_sql_server.html.markdown
Outdated
Show resolved
Hide resolved
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR adds the first linked service for data factory into the azurerm provider. We can move the common pieces of linked services into a umbrella resource as we learn more about what is shared between linked services.
Dependent on #3159