Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled AOF data persistence on Redis Cache #3155

Merged
merged 4 commits into from
Apr 4, 2019

Conversation

thatInfrastructureGuy
Copy link
Contributor

Adds support for the backup fields:

  • aof_backup_enabled
  • aof_storage_connection_string_0
  • aof_storage_connection_string_1

Fixes #2690

@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 4, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @thatInfrastructureGuy 👍

@tombuildsstuff
Copy link
Contributor

Ignoring a known bug in the Azure API (where disabling the backup causes a HTTP Timeout within Azure) - the tests pass:

Screenshot 2019-04-04 at 15 14 17

Thanks again for this @thatInfrastructureGuy

@tombuildsstuff tombuildsstuff merged commit 1233665 into hashicorp:master Apr 4, 2019
tombuildsstuff added a commit that referenced this pull request Apr 4, 2019
@thatInfrastructureGuy thatInfrastructureGuy deleted the redis/aof branch April 4, 2019 18:03
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AOF data persistence for redis_configuration in azurerm_redis_cache
2 participants