add gateway_bypass property

[Lucretius]

Resolves #3027 by adding the ability to set express_route_gateway_bypass

[katbyte]

Thanks for the PR @Lucretius,

Is there a reason we are not reading the value back in on read 🤔

Aside from that could we add this property to a test for verification?

[Lucretius]

Looks like I was following along with what was done for the other expressroute property - I can add them both to the read func. I will also add it to a test.

[katbyte]

Thanks for adding the test, aside from the test resources being named test_1 this LGTM 👍

Tests are failing with:

resource 'azurerm_express_route_circuit.test' config: unknown resource 'azurerm_resource_group.test' referenced in variable azurerm_resource_group.test.name
        - resource 'azurerm_express_route_circuit.test' config: unknown resource 'azurerm_resource_group.test' referenced in variable azurerm_resource_group.test.location

[Lucretius]

Gah, sorry you've had to act as my debugger on this. I do my acceptance testing with a personal subscription of Azure so some of these resources I am hesitant to run when I don't quite understand all of the resource billing :)

[tombuildsstuff]

@Lucretius no worries - I've kicked off the tests again so we'll find out shortly 👍

[katbyte]

Test ended with the error:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualNetworkGatewayConnection_expressroute
=== PAUSE TestAccAzureRMVirtualNetworkGatewayConnection_expressroute
=== CONT  TestAccAzureRMVirtualNetworkGatewayConnection_expressroute
--- FAIL: TestAccAzureRMVirtualNetworkGatewayConnection_expressroute (885.46s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* azurerm_virtual_network_gateway_connection.test: 1 error occurred:
        	* azurerm_virtual_network_gateway_connection.test: Error waiting for completion of Virtual Network Gateway Connection "acctest-190328215702318119" (Resource Group "acctestRG-190328215702318119"): Code="InvalidOperation" Message="ExpressRouteGatewayByPass is not enabled for this circuit acctest-erc-190328215702318119" Details=[]
        
        
        
        
    testing.go:599: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

[Lucretius]

I’ll go back to the drawing board and try to get a better understanding of this resource before I adjust the test any further. Looks like there is something I am not understanding about how this should be operating. Thanks!

[tombuildsstuff]

@Lucretius 👋 would you be able to reach out? [first name]@[company].[com]

[Lucretius]

Sure thing @tombuildsstuff - feel free to reach me at [email protected]

[Lucretius]

Looks like this logic was included in a recent pull request, closing this PR.

[ghost]

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!