-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU support for Linux Azure Container Instances #3053
Add GPU support for Linux Azure Container Instances #3053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @neilpeterson
Thanks for this PR :)
Taking a look through this mostly LGTM - I've left some minor comments inline but if we can get those fixed up this should be good to merge 👍
Thanks!
@tombuildsstuff thanks for the coaching and suggestions Tom. I've addressed each of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @neilpeterson
Thanks for pushing those changes - besides a couple of minor fixes needed for the test to pass (where the field had been renamed but the assertion hadn't) this otherwise LGTM 👍. I hope you don't mind but since the assertion is the only thing pending, so that we can get this merged I'm going to push a commit to fix this
Thanks!
@tombuildsstuff thanks a bunch for helping push this through. |
This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.24.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Issue - #3052