-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: azurerm_recovery_services_protection_policy_vm
#2974
New Data Source: azurerm_recovery_services_protection_policy_vm
#2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mcharriere
Thanks for this PR :)
I've taken a look through and left a couple of comments inline, but if we can fix those up this otherwise LGTM 👍
Thanks!
azurerm_recovery_services_protection_policy_vm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mcharriere
Thanks for pushing those changes - this now LGTM - I'll kick off the tests shortly 👍
Thanks!
Thanks! |
Tests pass: Thanks again for this @mcharriere :) |
This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.23.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Added data source for azurerm_recovery_services_protection_policy_vm
Fixes #2311