Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_*: fall back to vault_uri for resources created prior to 1.22 #2874

Merged
merged 4 commits into from
Feb 12, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Feb 12, 2019

fixes #2865

@katbyte katbyte added this to the 1.23.0 milestone Feb 12, 2019
@ghost ghost added the size/S label Feb 12, 2019
@ghost ghost added size/M and removed size/S labels Feb 12, 2019
@katbyte katbyte modified the milestones: 1.23.0, 1.22.1 Feb 12, 2019
@katbyte katbyte changed the title azurerm_key_vault_*: fall back to vault_uri for resources creasted prior to 1.22 azurerm_key_vault_*: fall back to vault_uri for resources created prior to 1.22 Feb 12, 2019
@katbyte katbyte force-pushed the keyvault/fix_child_url branch from c584df1 to ad21e0f Compare February 12, 2019 20:03
@ghost ghost added size/XL and removed size/M labels Feb 12, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit 7a5c7ef into master Feb 12, 2019
@katbyte katbyte deleted the keyvault/fix_child_url branch February 12, 2019 21:04
tombuildsstuff added a commit that referenced this pull request Feb 13, 2019
joakimhew pushed a commit to joakimhew/terraform-provider-azurerm that referenced this pull request Feb 23, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm 1.22 Error checking if key vault "" Exists
3 participants