-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mssql_managed_instance
fix identity
bug and updating subnet_id
#28319
Draft
wyattfry
wants to merge
4
commits into
main
Choose a base branch
from
wyatt/mssql-managed-instance-identity-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+435
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/mssqlmanagedinstance
waiting-response
and removed
waiting-response
labels
Dec 18, 2024
wyattfry
changed the title
wip
Dec 19, 2024
azurerm_mssql_managed_instance
fix identity bug and subnet changing
wyattfry
changed the title
Dec 19, 2024
azurerm_mssql_managed_instance
fix identity bug and subnet changingazurerm_mssql_managed_instance
fix identity bug and updating subnet_id
wyattfry
changed the title
Dec 19, 2024
azurerm_mssql_managed_instance
fix identity bug and updating subnet_id
azurerm_mssql_managed_instance
fix identity
bug and updating subnet_id
wyattfry
commented
Dec 19, 2024
@@ -181,7 +180,7 @@ func (r MsSqlManagedInstanceResource) Arguments() map[string]*pluginsdk.Schema { | |||
ValidateFunc: validate.ManagedInstanceID, | |||
}, | |||
|
|||
"identity": commonschema.SystemOrUserAssignedIdentityOptional(), | |||
"identity": commonschema.SystemAssignedUserAssignedIdentityOptional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the crux of the identity bug fix, SystemOrUserAssignedIdentityOptional
is XOR, exclusive or. SystemAssignedUserAssignedIdentityOption
is true OR, i.e. one, the other, or both.
…r-azurerm into wyatt/mssql-managed-instance-identity-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.