Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_trusted_signing_certificate_profile - new resource support #28191

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Dec 6, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New Resource for Trusted Signing reference

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
❯❯ tftest codesigning TestAccTrustedSigningCertificateProfile_     
=== RUN   TestAccTrustedSigningCertificateProfile_basic
=== PAUSE TestAccTrustedSigningCertificateProfile_basic
=== RUN   TestAccTrustedSigningCertificateProfile_requiresImport
=== PAUSE TestAccTrustedSigningCertificateProfile_requiresImport
=== RUN   TestAccTrustedSigningCertificateProfile_update
=== PAUSE TestAccTrustedSigningCertificateProfile_update
=== CONT  TestAccTrustedSigningCertificateProfile_basic
=== CONT  TestAccTrustedSigningCertificateProfile_requiresImport
=== CONT  TestAccTrustedSigningCertificateProfile_update
--- PASS: TestAccTrustedSigningCertificateProfile_requiresImport (398.93s)
--- PASS: TestAccTrustedSigningCertificateProfile_basic (410.95s)
--- PASS: TestAccTrustedSigningCertificateProfile_update (521.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/codesigning	521.212s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27843

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Dec 9, 2024

new test result:

❯❯ tftest codesigning TestAccTrustedSigningCertificateProfile_
=== RUN   TestAccTrustedSigningCertificateProfile_basic
=== PAUSE TestAccTrustedSigningCertificateProfile_basic
=== RUN   TestAccTrustedSigningCertificateProfile_requiresImport
=== PAUSE TestAccTrustedSigningCertificateProfile_requiresImport
=== RUN   TestAccTrustedSigningCertificateProfile_update
=== PAUSE TestAccTrustedSigningCertificateProfile_update
=== CONT  TestAccTrustedSigningCertificateProfile_basic
=== CONT  TestAccTrustedSigningCertificateProfile_update
=== CONT  TestAccTrustedSigningCertificateProfile_requiresImport
--- PASS: TestAccTrustedSigningCertificateProfile_requiresImport (355.54s)
--- PASS: TestAccTrustedSigningCertificateProfile_basic (400.72s)
--- PASS: TestAccTrustedSigningCertificateProfile_update (499.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/codesigning	499.579s

@magodo
Copy link
Collaborator

magodo commented Dec 10, 2024

LGTM, thank you!

@ziyeqf ziyeqf marked this pull request as ready for review December 11, 2024 00:06
@ziyeqf ziyeqf requested a review from a team as a code owner December 11, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Trusted Signing Account Certificate Profiles
4 participants