Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app, data.azurerm_container_app - support for additional_port_mapping in ingress block #28148

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Dec 2, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This pr added a new additional_port_mapping block in ingress block. It should solve #23442

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== RUN TestAccContainerAppDataSource_basic
=== PAUSE TestAccContainerAppDataSource_basic
=== RUN TestAccContainerAppDataSource_complete
=== PAUSE TestAccContainerAppDataSource_complete
=== CONT TestAccContainerAppDataSource_basic
=== CONT TestAccContainerAppDataSource_complete
--- PASS: TestAccContainerAppDataSource_basic (603.13s)
--- PASS: TestAccContainerAppDataSource_complete (663.33s)
=== RUN TestAccContainerAppResource_basic
=== PAUSE TestAccContainerAppResource_basic
=== RUN TestAccContainerAppResource_workloadProfile
=== PAUSE TestAccContainerAppResource_workloadProfile
=== RUN TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== PAUSE TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== RUN TestAccContainerAppResource_withSystemAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAssignedIdentity
=== RUN TestAccContainerAppResource_withUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withUserAssignedIdentity
=== RUN TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== RUN TestAccContainerAppResource_withIdentityUpdate
=== PAUSE TestAccContainerAppResource_withIdentityUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== RUN TestAccContainerAppResource_basicUpdate
=== PAUSE TestAccContainerAppResource_basicUpdate
=== RUN TestAccContainerAppResource_requiresImport
=== PAUSE TestAccContainerAppResource_requiresImport
=== RUN TestAccContainerAppResource_complete
=== PAUSE TestAccContainerAppResource_complete
=== RUN TestAccContainerAppResource_completeVolumeEmptyDir
=== PAUSE TestAccContainerAppResource_completeVolumeEmptyDir
=== RUN TestAccContainerAppResource_completeWithNoDaprAppPort
=== PAUSE TestAccContainerAppResource_completeWithNoDaprAppPort
=== RUN TestAccContainerAppResource_completeWithVNet
=== PAUSE TestAccContainerAppResource_completeWithVNet
=== RUN TestAccContainerAppResource_completeWithSidecar
=== PAUSE TestAccContainerAppResource_completeWithSidecar
=== RUN TestAccContainerAppResource_completeWithMultipleContainers
=== PAUSE TestAccContainerAppResource_completeWithMultipleContainers
=== RUN TestAccContainerAppResource_completeUpdate
=== PAUSE TestAccContainerAppResource_completeUpdate
=== RUN TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== RUN TestAccContainerAppResource_removeDaprAppPort
=== PAUSE TestAccContainerAppResource_removeDaprAppPort
=== RUN TestAccContainerAppResource_secretChangeName
=== PAUSE TestAccContainerAppResource_secretChangeName
=== RUN TestAccContainerAppResource_secretRemove
=== PAUSE TestAccContainerAppResource_secretRemove
=== RUN TestAccContainerAppResource_scaleRules
=== PAUSE TestAccContainerAppResource_scaleRules
=== RUN TestAccContainerAppResource_multipleScaleRules
=== PAUSE TestAccContainerAppResource_multipleScaleRules
=== RUN TestAccContainerAppResource_scaleRulesUpdate
=== PAUSE TestAccContainerAppResource_scaleRulesUpdate
=== RUN TestAccContainerAppResource_ipSecurityRulesUpdate
=== PAUSE TestAccContainerAppResource_ipSecurityRulesUpdate
=== RUN TestAccContainerAppResource_ingressTrafficValidation
=== PAUSE TestAccContainerAppResource_ingressTrafficValidation
=== RUN TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== PAUSE TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== CONT TestAccContainerAppResource_basic
=== CONT TestAccContainerAppResource_completeWithVNet
=== CONT TestAccContainerAppResource_secretRemove
=== CONT TestAccContainerAppResource_removeDaprAppPort
=== CONT TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== CONT TestAccContainerAppResource_completeTcpExposedPort
=== CONT TestAccContainerAppResource_secretChangeName
=== CONT TestAccContainerAppResource_completeWithMultipleContainers
=== CONT TestAccContainerAppResource_completeUpdate
=== CONT TestAccContainerAppResource_completeWithSidecar
=== CONT TestAccContainerAppResource_complete
=== CONT TestAccContainerAppResource_completeWithNoDaprAppPort
=== CONT TestAccContainerAppResource_completeVolumeEmptyDir
=== CONT TestAccContainerAppResource_withSystemAssignedIdentity
=== CONT TestAccContainerAppResource_withIdentityUpdate
=== CONT TestAccContainerAppResource_withSystemAndUserAssignedIdentity
--- PASS: TestAccContainerAppResource_completeWithNoDaprAppPort (567.57s)
=== CONT TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_withSystemAndUserAssignedIdentity (631.74s)
--- PASS: TestAccContainerAppResource_basic (646.26s)
=== CONT TestAccContainerAppResource_ipSecurityRulesUpdate
--- PASS: TestAccContainerAppResource_removeDaprAppPort (665.38s)
=== CONT TestAccContainerAppResource_maxInactiveRevisionsUpdate
--- PASS: TestAccContainerAppResource_withSystemAssignedIdentity (665.57s)
=== CONT TestAccContainerAppResource_ingressTrafficValidation
--- PASS: TestAccContainerAppResource_ingressTrafficValidation (6.68s)
=== CONT TestAccContainerAppResource_basicUpdate
--- PASS: TestAccContainerAppResource_secretRemove (672.78s)
=== CONT TestAccContainerAppResource_requiresImport
--- PASS: TestAccContainerAppResource_completeUpdate (677.83s)
=== CONT TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
--- PASS: TestAccContainerAppResource_complete (690.53s)
=== CONT TestAccContainerAppResource_multipleScaleRules
--- PASS: TestAccContainerAppResource_completeWithSidecar (693.16s)
=== CONT TestAccContainerAppResource_scaleRulesUpdate
--- PASS: TestAccContainerAppResource_completeWithMultipleContainers (710.02s)
=== CONT TestAccContainerAppResource_scaleRules
--- PASS: TestAccContainerAppResource_completeVolumeEmptyDir (721.59s)
=== CONT TestAccContainerAppResource_workloadProfile
=== CONT TestAccContainerAppResource_withUserAssignedIdentity
--- PASS: TestAccContainerAppResource_secretChangeName (726.70s)
--- PASS: TestAccContainerAppResource_withIdentityUpdate (744.50s)
--- PASS: TestAccContainerAppResource_completeTcpExposedPort (1000.37s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate (1023.90s)
--- PASS: TestAccContainerAppResource_completeWithVNet (1042.43s)
--- PASS: TestAccContainerAppResource_requiresImport (627.52s)
--- PASS: TestAccContainerAppResource_scaleRules (596.93s)
--- PASS: TestAccContainerAppResource_basicUpdate (641.92s)
--- PASS: TestAccContainerAppResource_multipleScaleRules (626.96s)
--- PASS: TestAccContainerAppResource_withUserAssignedIdentity (592.47s)
--- PASS: TestAccContainerAppResource_maxInactiveRevisionsUpdate (686.10s)
--- PASS: TestAccContainerAppResource_scaleRulesUpdate (709.43s)
--- PASS: TestAccContainerAppResource_ipSecurityRulesUpdate (856.75s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate (1175.85s)
--- PASS: TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations (1977.41s)
--- PASS: TestAccContainerAppResource_workloadProfile (1945.72s)
--- PASS: TestAccContainerAppResource_workloadProfileUpdate (2213.81s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23442

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for additionalPortMappings in azurerm_container_app
1 participant