-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_search_service
allows configuration of network_rule_bypass_option
#28139
Conversation
…_option` Refs: hashicorp#26575 Signed-off-by: patst <[email protected]>
…_option` Refs: hashicorp#26575 Signed-off-by: patst <[email protected]>
…_option` Refs: hashicorp#26575 Signed-off-by: patst <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @patst! This looks good, unfortunately I can't kick off the acceptance tests because of the merge conflict. Could you resolve it?
@stephybun thanks for taking a look! I fixed the merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @patst LGTM 💯
* Update CHANGELOG.md for #26304 * Update CHANGELOG.md for #28211 * Update for #28016 * Update for #28139 * Update for #27776 * Update for #28227 * Update for #28080 * Update for #28228 * Update for #27915 * reword nginx api upgrade * Update for #28160 * Update for #28043 * run changelog-update-for-release.sh --------- Co-authored-by: stephybun <[email protected]> Co-authored-by: kt <[email protected]>
Allows configuration of
network_rule_bypass_option
for theazurerm_search_service
resource.Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_search_service
- support for thenetwork_rule_bypass_option
property [azurerm_search_service should support the "Allow Azure services on the trusted services list to access this search service"-flag #26575]This is a (please select all that apply):
Related Issue(s)
Fixes #26575
Note
If this PR changes meaningfully during the course of review please update the title and description as required.