Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network , azurerm_subnet: Add 'Informatica.DataManagement/organizations' service name to service endpoint allowed values. #27993

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

CorrenSoft
Copy link
Contributor

@CorrenSoft CorrenSoft commented Nov 12, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

  • Added 'Informatica.DataManagement/organizations' to the allowed service names in subnet delegations.
  • Updated docs, including some missing values in this property.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

TestAccVirtualNetwork_edgeZone fails because I was unable to register the Microsoft.EdgeZones in my subscription.

TF_ACC=1 go test -v ./internal/services/network -run=TestAccSubnet_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSubnet_basic
=== PAUSE TestAccSubnet_basic
=== RUN   TestAccSubnet_basic_addressPrefixes
=== PAUSE TestAccSubnet_basic_addressPrefixes
=== RUN   TestAccSubnet_complete_addressPrefixes
=== PAUSE TestAccSubnet_complete_addressPrefixes
=== RUN   TestAccSubnet_update_addressPrefixes
=== PAUSE TestAccSubnet_update_addressPrefixes
=== RUN   TestAccSubnet_requiresImport
=== PAUSE TestAccSubnet_requiresImport
=== RUN   TestAccSubnet_disappears
=== PAUSE TestAccSubnet_disappears
=== RUN   TestAccSubnet_defaultOutbound
=== PAUSE TestAccSubnet_defaultOutbound
=== RUN   TestAccSubnet_delegation
=== PAUSE TestAccSubnet_delegation
=== RUN   TestAccSubnet_privateEndpointNetworkPolicies
=== PAUSE TestAccSubnet_privateEndpointNetworkPolicies
=== RUN   TestAccSubnet_enablePrivateLinkServiceNetworkPolicies
=== PAUSE TestAccSubnet_enablePrivateLinkServiceNetworkPolicies
=== RUN   TestAccSubnet_serviceEndpoints
=== PAUSE TestAccSubnet_serviceEndpoints
=== RUN   TestAccSubnet_serviceEndpointPolicy
=== PAUSE TestAccSubnet_serviceEndpointPolicy
=== RUN   TestAccSubnet_updateAddressPrefix
=== PAUSE TestAccSubnet_updateAddressPrefix
=== RUN   TestAccSubnet_privateLinkEndpointNetworkPoliciesValidateDefaultValues
=== PAUSE TestAccSubnet_privateLinkEndpointNetworkPoliciesValidateDefaultValues
=== RUN   TestAccSubnet_updateServiceDelegation
=== PAUSE TestAccSubnet_updateServiceDelegation
=== CONT  TestAccSubnet_basic
=== CONT  TestAccSubnet_enablePrivateLinkServiceNetworkPolicies
=== CONT  TestAccSubnet_privateEndpointNetworkPolicies
=== CONT  TestAccSubnet_updateServiceDelegation
=== CONT  TestAccSubnet_privateLinkEndpointNetworkPoliciesValidateDefaultValues
=== CONT  TestAccSubnet_updateAddressPrefix
=== CONT  TestAccSubnet_serviceEndpointPolicy
=== CONT  TestAccSubnet_serviceEndpoints
=== CONT  TestAccSubnet_requiresImport
--- PASS: TestAccSubnet_basic (663.11s)
--- PASS: TestAccSubnet_privateLinkEndpointNetworkPoliciesValidateDefaultValues (673.08s)
=== CONT  TestAccSubnet_delegation
--- PASS: TestAccSubnet_updateAddressPrefix (947.25s)
=== CONT  TestAccSubnet_defaultOutbound
--- PASS: TestAccSubnet_serviceEndpointPolicy (997.21s)
=== CONT  TestAccSubnet_disappears
--- PASS: TestAccSubnet_requiresImport (400.46s)
=== CONT  TestAccSubnet_complete_addressPrefixes
--- PASS: TestAccSubnet_enablePrivateLinkServiceNetworkPolicies (1141.77s)
=== CONT  TestAccSubnet_update_addressPrefixes
--- PASS: TestAccSubnet_updateServiceDelegation (1362.52s)
=== CONT  TestAccSubnet_basic_addressPrefixes
--- PASS: TestAccSubnet_disappears (397.12s)
--- PASS: TestAccSubnet_complete_addressPrefixes (534.19s)
--- PASS: TestAccSubnet_privateEndpointNetworkPolicies (1601.25s)
--- PASS: TestAccSubnet_serviceEndpoints (1626.95s)
--- PASS: TestAccSubnet_defaultOutbound (756.88s)
--- PASS: TestAccSubnet_basic_addressPrefixes (496.75s)
--- PASS: TestAccSubnet_update_addressPrefixes (931.00s)
--- PASS: TestAccSubnet_delegation (1399.83s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       2073.527s
make acctests SERVICE='network' TESTARGS='-run=TestAccVirtualNetwork_'

=== RUN   TestAccVirtualNetwork_basic
=== PAUSE TestAccVirtualNetwork_basic
=== RUN   TestAccVirtualNetwork_complete
=== PAUSE TestAccVirtualNetwork_complete
=== RUN   TestAccVirtualNetwork_updateFlowTimeoutInMinutes
=== PAUSE TestAccVirtualNetwork_updateFlowTimeoutInMinutes
=== RUN   TestAccVirtualNetwork_basicUpdated
=== PAUSE TestAccVirtualNetwork_basicUpdated
=== RUN   TestAccVirtualNetwork_requiresImport
=== PAUSE TestAccVirtualNetwork_requiresImport
=== RUN   TestAccVirtualNetwork_ddosProtectionPlan
=== PAUSE TestAccVirtualNetwork_ddosProtectionPlan
=== RUN   TestAccVirtualNetwork_disappears
=== PAUSE TestAccVirtualNetwork_disappears
=== RUN   TestAccVirtualNetwork_withTags
=== PAUSE TestAccVirtualNetwork_withTags
=== RUN   TestAccVirtualNetwork_deleteSubnet
=== PAUSE TestAccVirtualNetwork_deleteSubnet
=== RUN   TestAccVirtualNetwork_bgpCommunity
=== PAUSE TestAccVirtualNetwork_bgpCommunity
=== RUN   TestAccVirtualNetwork_edgeZone
=== PAUSE TestAccVirtualNetwork_edgeZone
=== RUN   TestAccVirtualNetwork_subnet
=== PAUSE TestAccVirtualNetwork_subnet
=== RUN   TestAccVirtualNetwork_subnetRouteTable
=== PAUSE TestAccVirtualNetwork_subnetRouteTable
=== CONT  TestAccVirtualNetwork_basic
=== CONT  TestAccVirtualNetwork_withTags
=== CONT  TestAccVirtualNetwork_requiresImport
=== CONT  TestAccVirtualNetwork_updateFlowTimeoutInMinutes
=== CONT  TestAccVirtualNetwork_complete
=== CONT  TestAccVirtualNetwork_disappears
=== CONT  TestAccVirtualNetwork_ddosProtectionPlan
=== CONT  TestAccVirtualNetwork_basicUpdated
--- PASS: TestAccVirtualNetwork_disappears (303.25s)
=== CONT  TestAccVirtualNetwork_subnetRouteTable
--- PASS: TestAccVirtualNetwork_requiresImport (309.25s)
=== CONT  TestAccVirtualNetwork_bgpCommunity
--- PASS: TestAccVirtualNetwork_withTags (335.75s)
=== CONT  TestAccVirtualNetwork_edgeZone
--- PASS: TestAccVirtualNetwork_complete (444.32s)
=== CONT  TestAccVirtualNetwork_deleteSubnet
--- PASS: TestAccVirtualNetwork_basic (467.37s)
=== CONT  TestAccVirtualNetwork_subnet
=== NAME  TestAccVirtualNetwork_edgeZone
    testcase.go:173: Step 1/3 error: Error running apply: exit status 1

        Error: no extended locations were found for the location "westus"

          with data.azurerm_extended_locations.test,
          on terraform_plugin_test.tf line 33, in data "azurerm_extended_locations" "test":
          33: data "azurerm_extended_locations" "test" {

--- FAIL: TestAccVirtualNetwork_edgeZone (172.68s)
--- PASS: TestAccVirtualNetwork_ddosProtectionPlan (520.09s)
--- PASS: TestAccVirtualNetwork_basicUpdated (712.80s)
--- PASS: TestAccVirtualNetwork_subnetRouteTable (490.02s)
--- PASS: TestAccVirtualNetwork_deleteSubnet (384.88s)
--- PASS: TestAccVirtualNetwork_updateFlowTimeoutInMinutes (901.06s)
--- PASS: TestAccVirtualNetwork_bgpCommunity (596.69s)
--- PASS: TestAccVirtualNetwork_subnet (468.62s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27946

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…ames in subnet delegations.

Updated docs, including some missing values in this property..
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CorrenSoft LGTM 🍯

@@ -91,9 +92,9 @@ var subnetDelegationServiceNames = []string{
"Microsoft.Web/hostingEnvironments",
"Microsoft.Web/serverFarms",
"NGINX.NGINXPLUS/nginxDeployments",
"Oracle.Database/networkAttachments",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing the ordering here ❤️

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot believe that you guys actually merged my request for Informatica. Amazing. Thanks a lot!!!

@stephybun stephybun merged commit 852fb9a into hashicorp:main Nov 15, 2024
33 checks passed
@github-actions github-actions bot added this to the v4.11.0 milestone Nov 15, 2024
stephybun added a commit that referenced this pull request Nov 15, 2024
@CorrenSoft CorrenSoft deleted the feature/27946 branch November 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants