azurerm_monitor_workspace - add private_endpoint_connections export to resource and data source

[djryanj]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support for an exported list of private_endpoint_connections, to both azurerm_monitor_workspace resource and data sources. This is required in order for Terraform to (eventually) be able to automatically approve connections from e.g., an azurerm_dashboard_grafana_managed_private_endpoint.

Acceptance tests have been added for this, and a bit of cleanup to the overall acceptance test code for the resource (reduced duplicate code).

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Acceptance test output:

$ make acctests SERVICE='monitor' TESTARGS='-run=TestMonitorWorkspace_privateEndpointConnection' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/monitor -run=TestMonitorWorkspace_privateEndpointConnection -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestMonitorWorkspace_privateEndpointConnection
=== PAUSE TestMonitorWorkspace_privateEndpointConnection
=== CONT  TestMonitorWorkspace_privateEndpointConnection
--- PASS: TestMonitorWorkspace_privateEndpointConnection (866.73s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       866.747s

$ make acctests SERVICE='monitor' TESTARGS='-run=TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/monitor -run=TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection
=== PAUSE TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection
=== CONT  TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection
--- PASS: TestAccMonitorWorkspaceDataSourceDataSource_privateEndpointConnection (802.36s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       802.371s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_monitor_workspace - export private_endpoint_connections property [Support for private_endpoint_connections within azurerm_monitor_workspace resource and data source #27786]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27786

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[djryanj]

Added some extra changes to satisfy a few comments made in #27781.

New acceptance tests:

$ make acctests SERVICE='dashboard' TESTARGS='-run=TestAccDashboardGrafanaManagedPrivateEndpoint_' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/dashboard -run=TestAccDashboardGrafanaManagedPrivateEndpoint_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDashboardGrafanaManagedPrivateEndpoint_basic
--- PASS: TestAccDashboardGrafanaManagedPrivateEndpoint_basic (744.69s)
=== RUN   TestAccDashboardGrafanaManagedPrivateEndpoint_requiresImport
--- PASS: TestAccDashboardGrafanaManagedPrivateEndpoint_requiresImport (714.27s)
=== RUN   TestAccDashboardGrafanaManagedPrivateEndpoint_complete
--- PASS: TestAccDashboardGrafanaManagedPrivateEndpoint_complete (807.23s)
=== RUN   TestAccDashboardGrafanaManagedPrivateEndpoint_update
--- PASS: TestAccDashboardGrafanaManagedPrivateEndpoint_update (682.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/dashboard     2949.151s

[Poltergeisen]

looking forward to this!