azurerm_sentinel_alert_rule_scheduled - remove the limit on number of entity_mapping and sentinel_entity_mapping

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The limit of the number changed to 10 from 5, since the limit is on service side, can we remove the limit and let the service return that error?

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

❯❯ tftest sentinel TestAccSentinelAlertRuleScheduled
=== RUN   TestAccSentinelAlertRuleScheduled_basic
=== PAUSE TestAccSentinelAlertRuleScheduled_basic
=== RUN   TestAccSentinelAlertRuleScheduled_upgrade
=== PAUSE TestAccSentinelAlertRuleScheduled_upgrade
=== RUN   TestAccSentinelAlertRuleScheduled_complete
=== PAUSE TestAccSentinelAlertRuleScheduled_complete
=== RUN   TestAccSentinelAlertRuleScheduled_update
=== PAUSE TestAccSentinelAlertRuleScheduled_update
=== RUN   TestAccSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccSentinelAlertRuleScheduled_requiresImport
=== RUN   TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== PAUSE TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== RUN   TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== PAUSE TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== CONT  TestAccSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccSentinelAlertRuleScheduled_basic
=== CONT  TestAccSentinelAlertRuleScheduled_update
=== CONT  TestAccSentinelAlertRuleScheduled_complete
=== CONT  TestAccSentinelAlertRuleScheduled_upgrade
=== CONT  TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== CONT  TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
--- PASS: TestAccSentinelAlertRuleScheduled_requiresImport (248.72s)
--- PASS: TestAccSentinelAlertRuleScheduled_complete (274.89s)
--- PASS: TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid (279.40s)
--- PASS: TestAccSentinelAlertRuleScheduled_basic (280.69s)
--- PASS: TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting (372.15s)
--- PASS: TestAccSentinelAlertRuleScheduled_upgrade (375.55s)
--- PASS: TestAccSentinelAlertRuleScheduled_update (434.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel	434.732s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_sentinel_alert_rule_scheduled - remove the limit on number of entity_mapping and sentinel_entity_mapping [azurerm_sentinel_alert_rule_scheduled - remove the limit on number of entity_mapping and sentinel_entity_mapping #27832]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27722

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Hey @ziyeqf, whether we remove the validation and rely on the API's validation depends on the behaviour and the error message that's returned. Does the API return a helpful error message when this limit is exceeded?

What is the correct limit for both entity_mapping and sentinel_entity_mapping now?

[stephybun]

Has the limit for the sentinel entity mapping also been affected?

[ziyeqf]

While, per further testing, it requires an API update, will close this PR and open another to upgrade the API version first.

[Stanislava27]

@ziyeqf, can this PR be reopened after API update PR is merged (#28074)?

[ziyeqf]

@ziyeqf, can this PR be reopened after API update PR is merged (#28074)?

It requires API version update for sentinel, I'm currently working on it.

[ziyeqf]

The limit update and API version upgrade will be done by #28195