-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update costmanagement API to 2023-08-01 #27680
base: main
Are you sure you want to change the base?
Conversation
This change updates the costmanagement API to version 2023-08-01, ensuring compatibility with both the public Azure Cloud and AzureChinaCloud. It's important to note that AzureChinaCloud has specific API version requirements, and version 2023-08-01 meets these. In addition, the `azurerm_cost_anomaly_alert` resource now includes a new optional parameter, `email_address_sender`, introduced in this API version. Should this parameter be omitted, the the TF provider will default to using the first email address listed in `email_addresses`, aligning with the default behavior observed in the Azure Portal. The ScheduledActionsClient_v2022_10_01, which previously existed alongside the ScheduledActionsClient, has been discontinued. This is because the API version 2023-08-01 seems to be compatible with all uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @s4heid - we will need to update the docs with this new property.
@katbyte I added a commit to reflect the new parameter in the docs. |
@katbyte If the naming of |
Community Note
Description
This change updates the costmanagement API to version
2023-08-01
, ensuring compatibility with both the public AzureCloud and AzureChinaCloud. It's important to note that AzureChinaCloud has specific API version requirements, and version2023-08-01
meets these.In addition, the
azurerm_cost_anomaly_alert
resource now includes a new optional parameter,notification_email
, which is sent to the API asproperties.notificationEmail
. Should this parameter be omitted, the TF provider will default to using the first email address listed inemail_addresses
, aligning with the default behavior observed in the Azure Portal.The
ScheduledActionsClient_v2022_10_01
, which previously existed alongside theScheduledActionsClient
, has been discontinued. This is because the API version2023-08-01
seems to be compatible with all uses.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource_group_cost_management_export
- upgrade the API version to2023-08-01
which also supports AzureChinaCloudThis is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.
Additonal Context
When creating the resource with an old API version (let's say 2022-06-01-preview), the
properties.notificationEmail
isnull
in the response. With API version2023-11-01
, if you try to get the previously created alert, the response contains the first entry of the listproperties.notification.to
.