Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor Docs - add guide on deprecations and breaking changes #27654

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added a guide on how to do deprecations and breaking changes in the provider using the major release feature flag.

@stephybun stephybun requested review from rcskosir and a team October 15, 2024 09:08
Copy link
Contributor

@rcskosir rcskosir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple minor comments!


This deprecated resources has been removed from the Azure Provider.
```
**Note:** The Resource documentation does not need to be updated with a note since the provider will inform any users using the resource of the deprecation with a warning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is worth throwing a note into the resource docs anyway?

I'm thinking of a use case where I'm writing out a resource and get it all written just to find out when running Terraform that there is a new one to use instead and I could have written it out the new way instead of the old.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point. I'll update this to require a note in the docs for deprecated resources/datasources.

Breaking schema changes can include:
- Property renames
- When properties become Required
- When properties have Computed removed in some cases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we expand on what are some cases?

"version": {
Type: pluginsdk.TypeString,
Optional: true,
Default: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but I believe this wants to be 2 and the Default below wants to be 1 based on the wording of the example default going from 1 to 2

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🐃

@stephybun stephybun merged commit 50e6593 into main Oct 16, 2024
3 checks passed
@stephybun stephybun deleted the docs/deprecations-and-breaking-changes branch October 16, 2024 12:45
@github-actions github-actions bot added this to the v4.6.0 milestone Oct 16, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants