azurerm_sentinel_alert_rule_anomaly_duplicate - fix acctest

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

the old test case was kind of out of date and failing, so update the testing config.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

❯❯ tftest sentinel TestAccSentinelAlertRuleAnomalyDuplicate_
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_basic
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_basic
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_requiresImport
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_requiresImport
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_ThresholdWithCustomObservation
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_ThresholdWithCustomObservation
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_MultiSelectWithCustomObservation
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_MultiSelectWithCustomObservation
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_SingleSelectWithCustomObservation
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_SingleSelectWithCustomObservation
=== RUN   TestAccSentinelAlertRuleAnomalyDuplicate_PrioritizeExcludeWithCustomObservation
=== PAUSE TestAccSentinelAlertRuleAnomalyDuplicate_PrioritizeExcludeWithCustomObservation
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_basic
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_MultiSelectWithCustomObservation
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_PrioritizeExcludeWithCustomObservation
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_SingleSelectWithCustomObservation
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_ThresholdWithCustomObservation
=== CONT  TestAccSentinelAlertRuleAnomalyDuplicate_requiresImport
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_PrioritizeExcludeWithCustomObservation (198.71s)
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_requiresImport (243.28s)
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_MultiSelectWithCustomObservation (248.70s)
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_ThresholdWithCustomObservation (258.97s)
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_SingleSelectWithCustomObservation (269.69s)
--- PASS: TestAccSentinelAlertRuleAnomalyDuplicate_basic (270.62s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      272.607s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_sentinel_alert_rule_anomaly_duplicate - fix acctest [azurerm_sentinel_alert_rule_anomaly_duplicate - fix acctest #27635]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for fixing these tests up @ziyeqf. One really minor comment which would be good to have addressed since otherwise this would introduce a variation in the naming of tests. Once that's fixed up this should be good to go.

[stephybun]

Super minor, but test description are camelCased across the provider

Suggested change

	func TestAccSentinelAlertRuleAnomalyDuplicate_ThresholdWithCustomObservation(t *testing.T) {
	func TestAccSentinelAlertRuleAnomalyDuplicate_thresholdWithCustomObservation(t *testing.T) {

[stephybun]

Same here

[stephybun]

Same here

[stephybun]

Same here

[stephybun]

Thanks @ziyeqf LGTM ⚡

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.