Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_azure_sql_database - adding credential block #27629

Merged
merged 4 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"fmt"
"time"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-sdk/resource-manager/datafactory/2018-06-01/factories"
"github.com/hashicorp/terraform-provider-azurerm/helpers/tf"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
Expand Down Expand Up @@ -171,6 +172,12 @@ func resourceDataFactoryLinkedServiceAzureSQLDatabase() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
},
},

"credential_name": {
Type: pluginsdk.TypeString,
Optional: true,
ValidateFunc: validation.StringIsNotEmpty,
},
},
}
}
Expand Down Expand Up @@ -259,6 +266,12 @@ func resourceDataFactoryLinkedServiceAzureSQLDatabaseCreateUpdate(d *pluginsdk.R
azureSQLDatabaseLinkedService.Annotations = &annotations
}

if credentialName := d.Get("credential_name").(string); credentialName != "" {
azureSQLDatabaseLinkedService.Credential = &datafactory.CredentialReference{
ReferenceName: pointer.To(credentialName),
}
}

linkedService := datafactory.LinkedServiceResource{
Properties: azureSQLDatabaseLinkedService,
}
Expand Down Expand Up @@ -352,6 +365,10 @@ func resourceDataFactoryLinkedServiceAzureSQLDatabaseRead(d *pluginsdk.ResourceD
}
}

if credential := sql.Credential; credential != nil {
d.Set("credential_name", pointer.From(credential.ReferenceName))
}

return nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,22 @@ func TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultRef
})
}

func TestAccDataFactoryLinkedServiceAzureSQLDatabase_Credential(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_data_factory_linked_service_azure_sql_database", "test")
r := LinkedServiceAzureSQLDatabaseResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.credential(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("credential_name").HasValue(fmt.Sprintf("test%d", data.RandomInteger)),
),
},
data.ImportStep("connection_string"),
})
}

func (t LinkedServiceAzureSQLDatabaseResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
id, err := parse.LinkedServiceID(state.ID)
if err != nil {
Expand Down Expand Up @@ -355,3 +371,48 @@ resource "azurerm_data_factory_linked_service_azure_sql_database" "test" {
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger)
}

func (LinkedServiceAzureSQLDatabaseResource) credential(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-df-%d"
location = "%s"
}

resource "azurerm_user_assigned_identity" "test" {
name = "test%d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
}

resource "azurerm_data_factory" "test" {
name = "acctestdf%d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name

identity {
type = "SystemAssigned, UserAssigned"
identity_ids = [azurerm_user_assigned_identity.test.id]
}
}

resource "azurerm_data_factory_credential_user_managed_identity" "test" {
name = azurerm_user_assigned_identity.test.name
description = "Test ADF SQL DB UMI"
data_factory_id = azurerm_data_factory.test.id
identity_id = azurerm_user_assigned_identity.test.id
}

resource "azurerm_data_factory_linked_service_azure_sql_database" "test" {
name = "acctestlssql%d"
data_factory_id = azurerm_data_factory.test.id
connection_string = "data source=serverhostname;initial catalog=master;user id=testUser;Password=test;integrated security=False;encrypt=True;connection timeout=30"

credential_name = azurerm_data_factory_credential_user_managed_identity.test.name
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger)
}
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ The following arguments are supported:

* `key_vault_password` - (Optional) A `key_vault_password` block as defined below. Use this argument to store SQL Server password in an existing Key Vault. It needs an existing Key Vault Data Factory Linked Service.

* `credential_name` - (Optional) The name of a User-assigned Managed Identity. Use this argument to authenticate against the linked resource using a User-assigned Managed Identity.

---

A `key_vault_connection_string` block supports the following:
Expand Down
Loading